Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in 'type' parameter for command 'hab origin key export' #6934

Merged
merged 2 commits into from Sep 9, 2019

Conversation

@sirajrauff
Copy link
Contributor

commented Sep 5, 2019

Resolves #6933

Signed-off-by: Siraj Rauff sirajrauff@gmail.com

Signed-off-by: Siraj Rauff <sirajrauff@gmail.com>
@chef-expeditor

This comment has been minimized.

Copy link

commented Sep 5, 2019

Hello sirajrauff! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@smacfarlane smacfarlane requested a review from kagarmoe Sep 5, 2019
components/hab/src/cli.rs Outdated Show resolved Hide resolved
Copy link
Contributor

left a comment

Looks good, but it looks like we'll need a Signed-off-by: Siraj Rauff <sirajrauff@gmail.com> line in that second commit.

Update 'secret' definition to be inline with documentation Vocabulary

Co-Authored-By: Kimberly Garmoe <kgarmoe@chef.io>
Signed-off-by: Siraj Rauff <sirajrauff@gmail.com>
@sirajrauff sirajrauff force-pushed the sirajrauff:typo-fix branch from a725636 to 2215be1 Sep 6, 2019
@sirajrauff

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2019

@christophermaier amended & force-pushed. Should be good to go?

@christophermaier christophermaier merged commit b283e23 into habitat-sh:master Sep 9, 2019
4 of 5 checks passed
4 of 5 checks passed
buildkite/habitat-sh-habitat-master-verify Build #3344 passed and blocked (19 seconds)
Details
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-website Build #461 passed and blocked (17 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.