Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the trace_it! macro and associated functionality. #6936

Merged
merged 1 commit into from Sep 6, 2019

Conversation

@raskchanky
Copy link
Member

commented Sep 6, 2019

Ultimately, this feature isn't being used and its utility is limited to
just a couple of supervisors. Any more than that, and the output becomes
too much to make sense of. As part of cleaning up our deadlocks, we're
removing this. We might revisit something along these lines in the
future, but better suited to larger networks.

This is in service of #6435

Signed-off-by: Josh Black raskchanky@gmail.com

Ultimately, this feature isn't being used and its utility is limited to
just a couple of supervisors. Any more than that, and the output becomes
too much to make sense of. As part of cleaning up our deadlocks, we're
removing this. We might revisit something along these lines in the
future, but better suited to larger networks.

Signed-off-by: Josh Black <raskchanky@gmail.com>
@chef-expeditor

This comment has been minimized.

Copy link

commented Sep 6, 2019

Hello raskchanky! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@baumanj
baumanj approved these changes Sep 6, 2019
Copy link
Contributor

left a comment

Wow, I can't remember the last time I thought of Fire Marshall Bill. 💯

@raskchanky raskchanky merged commit 1157d88 into master Sep 6, 2019
5 checks passed
5 checks passed
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #3352 passed (23 minutes, 31 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #469 passed (35 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@raskchanky raskchanky deleted the jb/remove-trace branch Sep 6, 2019
christophermaier added a commit that referenced this pull request Sep 9, 2019
Follow up to #6936

Signed-off-by: Christopher Maier <cmaier@chef.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.