Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additionl e2e tests validating SSL cert functionality #7038

Merged
merged 1 commit into from Oct 25, 2019

Conversation

@smacfarlane
Copy link
Contributor

smacfarlane commented Oct 15, 2019

Additionally, some studio behavior is tested in this PR.

This adds tests to validate the following scenarios:

  • A fresh install of the hab cli can interact with Builder and install packages
  • An invalid certificate that has been cached is ignored by the hab cli
  • A custom certificate that has been cached manually is available in the studio
  • A self-signed certificate is loaded by the hab cli
  • An interactive studio can build packages with the build helper
  • The version of the hab cli embedded in the studio package is the correct version

This finishes the Linux portion of #6800
Signed-off-by: Scott Macfarlane smacfarlane@chef.io

@chef-expeditor

This comment has been minimized.

Copy link

chef-expeditor bot commented Oct 15, 2019

Hello smacfarlane! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@smacfarlane smacfarlane force-pushed the sm/add-ssl-e2e-tests branch from 2978a0a to 86329b8 Oct 15, 2019
@smacfarlane smacfarlane force-pushed the sm/add-ssl-e2e-tests branch from 86329b8 to c30e49d Oct 17, 2019
Copy link
Member

chefsalim left a comment

Looks GREAT!

@smacfarlane smacfarlane force-pushed the sm/add-ssl-e2e-tests branch from c30e49d to c686c67 Oct 24, 2019
Signed-off-by: Scott Macfarlane <smacfarlane@chef.io>
@smacfarlane smacfarlane force-pushed the sm/add-ssl-e2e-tests branch from c686c67 to 2ffb1b2 Oct 24, 2019
@smacfarlane smacfarlane merged commit 9c65677 into master Oct 25, 2019
5 checks passed
5 checks passed
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #3917 passed (22 minutes, 24 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #997 passed (37 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@chef-expeditor chef-expeditor bot deleted the sm/add-ssl-e2e-tests branch Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.