Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds version note to foundation.min.js #7042

Merged
merged 2 commits into from Oct 16, 2019

Conversation

@kagarmoe
Copy link
Collaborator

kagarmoe commented Oct 15, 2019

We're using a different version of Zurb's Foundation Sites for this site. Most of our other Foundations site use version 5xx. This adds a note so we won't be confused later on.
Signed-off-by: kagarmoe kgarmoe@chef.io

Signed-off-by: kagarmoe <kgarmoe@chef.io>
@kagarmoe kagarmoe requested a review from apriofrost Oct 15, 2019
@chef-expeditor

This comment has been minimized.

Copy link

chef-expeditor bot commented Oct 15, 2019

Hello kagarmoe! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

Signed-off-by: kagarmoe <kgarmoe@chef.io>
Copy link
Contributor

christophermaier left a comment

Looks good.

I'll go ahead and merge, because the rustfmt failure has nothing to do with this code. It's fixed on master, but there's no reason to rebase this to make that green.

@christophermaier christophermaier merged commit db2991c into master Oct 16, 2019
4 of 5 checks passed
4 of 5 checks passed
buildkite/habitat-sh-habitat-master-verify Build #3724 failed (18 minutes, 25 seconds)
Details
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-website Build #811 passed (55 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@chef-expeditor chef-expeditor bot deleted the kg/foundation branch Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.