Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows studios e2e tests to verify SSL_CERT_FILE behavior #7047

Merged
merged 1 commit into from Oct 23, 2019

Conversation

@smacfarlane
Copy link
Contributor

smacfarlane commented Oct 15, 2019

This is the windows studio equivalent of #6944 and address a portion of #6800. There will be a follow-on PR to this that will be the windows equivalent of #7038

This pulls in commits from #7027 and will need to be rebased once that PR is merged

  • windows studio: valid SSL_CERT_FILE
  • windows studio: invalid SSL_CERT_FILE
  • windows studio: SSL_CERT_FILE is a directory
  • windows studio: SSL_CERT_FILE points to non-existent file

Running the tests:

./e2e_local.ps1 test_studio_with_ssl_cert_file_envvar_set

@chef-expeditor

This comment has been minimized.

Copy link

chef-expeditor bot commented Oct 15, 2019

Hello smacfarlane! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@smacfarlane smacfarlane force-pushed the sm/add-ps1-studio-ssl-e2e-tests branch 2 times, most recently from 2ccee49 to f9661b5 Oct 17, 2019
@mwrock
mwrock approved these changes Oct 21, 2019
Copy link
Contributor

mwrock left a comment

this looks good to me. There is one item that should be addressed for correctness but does not affect this passing.

@smacfarlane smacfarlane force-pushed the sm/add-ps1-studio-ssl-e2e-tests branch from f9661b5 to d1de565 Oct 21, 2019
Signed-off-by: Scott Macfarlane <smacfarlane@chef.io>
@smacfarlane smacfarlane force-pushed the sm/add-ps1-studio-ssl-e2e-tests branch from d1de565 to 2f7d5c3 Oct 22, 2019
@smacfarlane smacfarlane merged commit 0f09411 into master Oct 23, 2019
5 checks passed
5 checks passed
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #3847 passed (31 minutes, 47 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #919 passed (38 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@chef-expeditor chef-expeditor bot deleted the sm/add-ps1-studio-ssl-e2e-tests branch Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.