Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes using a svc_user on windows #7049

Merged
merged 1 commit into from Oct 17, 2019

Conversation

@mwrock
Copy link
Contributor

mwrock commented Oct 16, 2019

fixes #6834

This addresses two key bugs around using a svc_user on windows.

  • Fixes the serialization of a spec to toml by moving the health check interval to the last field.
  • Ignores svc_user in the install hook and runs as the current user instead. This is because the install hook does not have access to the svc_user password.

Note there is an end to end test for this included in #7027

@chef-expeditor

This comment has been minimized.

Copy link

chef-expeditor bot commented Oct 16, 2019

Hello mwrock! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@mwrock mwrock self-assigned this Oct 16, 2019
@mwrock mwrock force-pushed the svc_password branch 2 times, most recently from 6f6c4cf to c4dd8a8 Oct 16, 2019
@mwrock mwrock force-pushed the svc_password branch from c4dd8a8 to cabadea Oct 17, 2019
Signed-off-by: mwrock <matt@mattwrock.com>
@mwrock mwrock force-pushed the svc_password branch from cabadea to c00ba63 Oct 17, 2019
@markan
markan approved these changes Oct 17, 2019
Copy link
Contributor

markan left a comment

Looks reasonable to me.

@mwrock mwrock merged commit 4c4f3fa into master Oct 17, 2019
5 checks passed
5 checks passed
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #3764 passed (37 minutes, 28 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #848 passed (7 minutes, 20 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@mwrock mwrock deleted the svc_password branch Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.