Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not use hab as default user on windows #7059

Merged
merged 1 commit into from Oct 18, 2019

Conversation

@mwrock
Copy link
Contributor

mwrock commented Oct 18, 2019

resolves #6847

This no longer treats hab as a default svc_user for windows. At the packaging level we no longer create a SVC_USER metafile with the hab user if no pkg_svc_user is specified. In the templating Pkg struct, if no svc_user exists, it assigns the svc_user to the current user. Finally in the supervisor, which is where its a bit ugly, we fallback to the current user if there is no svc_password AND the user is hab. See comments for more detail.

Also this changes any errors from windows account lookups to debug messages. The only time I have seen errors here are in lookup attempts to find a hab user that does not exist in some active directory environments. The error is harmless but makes it look like something is very wrong.

One last change I snuck in a couple of our plan.ps1 files:

function Invoke-Clean {
    if(!$env:HAB_SKIP_CLEAN) { Invoke-DefaultClean }
}

This is useful when developing and I don't want to do a clean.

Signed-off-by: mwrock matt@mattwrock.com

components/sup/src/manager/service.rs Outdated Show resolved Hide resolved
components/sup/src/manager/service.rs Outdated Show resolved Hide resolved
components/sup/src/manager/service.rs Outdated Show resolved Hide resolved
Copy link
Contributor

christophermaier left a comment

Looks good. I left some suggestions that could clarify things a bit more.

@mwrock mwrock force-pushed the win_default_user branch 3 times, most recently from 6f6b9af to e4edcff Oct 18, 2019
Signed-off-by: mwrock <matt@mattwrock.com>
@mwrock mwrock force-pushed the win_default_user branch from e4edcff to aaa745c Oct 18, 2019
@mwrock mwrock merged commit 78eeaeb into master Oct 18, 2019
5 checks passed
5 checks passed
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #3791 passed (33 minutes, 25 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #875 passed (59 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@mwrock mwrock deleted the win_default_user branch Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.