Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hab pkg download file can have comments, whitespace #7064

Merged
merged 1 commit into from Oct 21, 2019

Conversation

@markan
Copy link
Contributor

markan commented Oct 18, 2019

As reported in #7040, the file reader for hab pkg download is fragile. Trailing whitespace gives an
unpleasant error, and there's no way to comment. This alters the file reader to ignore whitespace,
and adds '#' as a comment character, similar to the usage in many other interpreted languages.

Closes #7040

Signed-off-by: Mark Anderson mark@chef.io

@markan markan force-pushed the ma/hab-7040/handle_whitespace_and_comments branch 2 times, most recently from b9cdf05 to d5ad80f Oct 18, 2019
Copy link
Member

chefsalim left a comment

LGTM

Copy link
Contributor

christophermaier left a comment

As reported in #7040, the file reader for hab pkg download is fragile. Trailing whitespace gives an
unpleasant error, and there's no way to comment. This alters the file reader to ignore whitespace,
and adds '#' as a comment character, similar to the usage in many other interpreted languages.

Signed-off-by: Mark Anderson <mark@chef.io>
@markan markan force-pushed the ma/hab-7040/handle_whitespace_and_comments branch from d5ad80f to f066879 Oct 21, 2019
@markan markan merged commit 0cd61c5 into master Oct 21, 2019
5 checks passed
5 checks passed
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #3812 passed (17 minutes, 2 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #896 passed (44 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@markan markan deleted the ma/hab-7040/handle_whitespace_and_comments branch Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.