Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make pkg download fail when zero packages #7068

Merged
merged 1 commit into from Oct 21, 2019
Merged

Conversation

@markan
Copy link
Contributor

markan commented Oct 18, 2019

Currently the hab pkg download command silently succeeds when no
packages are provided. Thus likely us a user error, and we should fail
with a useful error message instead.

closes #7055

Signed-off-by: Mark Anderson mark@chef.io

Copy link
Member

chefsalim left a comment

Copy link
Contributor

christophermaier left a comment

Currently the hab pkg download command silently succeeds when no
packages are provided. Thus likely us a user error, and we should fail
with a useful error message instead.

closes #7055

Signed-off-by: Mark Anderson <mark@chef.io>
@markan markan force-pushed the ma/hab_7055/fail_with_no_idents branch from 2a1cbd7 to fafae28 Oct 21, 2019
@markan markan merged commit 4dfdab6 into master Oct 21, 2019
5 checks passed
5 checks passed
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #3801 passed (37 minutes, 52 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #885 passed (38 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@markan markan deleted the ma/hab_7055/fail_with_no_idents branch Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.