Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ma/hab 7056/message cleanup #7069

Merged
merged 2 commits into from Oct 21, 2019

Conversation

@markan
Copy link
Contributor

markan commented Oct 19, 2019

Simplify hab pkg download output. The current output is redundant and is difficult to use in narrow console windows.

This PR removes some redundant messages, shortens lines, and generally cleans up the output. I've tested it and it looks good in 80 columns. Also clean up some typos.

closes #7056
closes #7054

mark@souschef{111}% ../habitat/target/debug/hab pkg download --download-directory foo --target x86_64-linux  core/gzip
» Resolving dependencies for 1 package idents
» Using channel stable from https://bldr.habitat.sh
» Using target x86_64-linux
» Storing in download directory "foo" 
☛ Verifying the download directory "foo"
☁ Determining latest version of core/gzip
→ Using core/gzip/1.9/20190115013612
→ Found 8 artifacts
↓ Downloading Downloading 8 artifacts (and their signing keys)
… Using cached core/less/530/20190115013008
… Using cached core/linux-headers/4.17.12/20190115002705
… Using cached core/glibc/2.27/20190115002733
… Using cached core/gcc-libs/8.2.0/20190115011926
… Using cached core/grep/3.1/20190115012541
… Using cached core/ncurses/6.1/20190115012027
… Using cached core/gzip/1.9/20190115013612
… Using cached core/pcre/8.42/20190115012526
mark@souschef{111}% rm -rf foo
mark@souschef{112}% ../habitat/target/debug/hab pkg download --download-directory foo --target x86_64-linux  core/gzip
» Resolving dependencies for 1 package idents
» Using channel stable from https://bldr.habitat.sh
» Using target x86_64-linux
» Storing in download directory "foo" 
☛ Verifying the download directory "foo"
☁ Determining latest version of core/gzip
→ Using core/gzip/1.9/20190115013612
→ Found 8 artifacts
↓ Downloading Downloading 8 artifacts (and their signing keys)
↓ Downloading core/linux-headers/4.17.12/20190115002705
    965.22 KB / 965.22 KB | [==============================] 100.00 % 5.91 MB/s 
↓ Downloading public key for signer "core-20180119235000"
    75 B / 75 B | [======================================] 100.00 % 474.64 KB/s 
↓ Downloading core/ncurses/6.1/20190115012027
    848.13 KB / 848.13 KB - [==============================] 100.00 % 5.29 MB/s 
↓ Downloading core/gcc-libs/8.2.0/20190115011926
    3.33 MB / 3.33 MB / [==================================] 100.00 % 7.92 MB/s 
↓ Downloading core/glibc/2.27/20190115002733
    13.83 MB / 13.83 MB - [================================] 100.00 % 9.31 MB/s 
↓ Downloading core/less/530/20190115013008
    83.00 KB / 83.00 KB - [================================] 100.00 % 1.64 MB/s 
↓ Downloading core/pcre/8.42/20190115012526
    737.67 KB / 737.67 KB / [==============================] 100.00 % 4.75 MB/s 
↓ Downloading core/gzip/1.9/20190115013612
    61.76 KB / 61.76 KB \ [================================] 100.00 % 1.35 MB/s 
↓ Downloading core/grep/3.1/20190115012541
    170.21 KB / 170.21 KB / [==============================] 100.00 % 2.28 MB/s
Copy link
Member

chefsalim left a comment

Copy link
Contributor

christophermaier left a comment

markan added 2 commits Oct 18, 2019
Signed-off-by: Mark Anderson <mark@chef.io>
The current output is redundant and is difficult to use in narrow
console windows.

This PR removes some redundant messages, shortens lines, and generally
cleans up the output. I've tested it and it looks good in 80
columns.

closes #7056

Signed-off-by: Mark Anderson <mark@chef.io>
@markan markan force-pushed the ma/hab_7056/message_cleanup branch from 12010d3 to def029f Oct 21, 2019
@markan markan merged commit 5d14414 into master Oct 21, 2019
5 checks passed
5 checks passed
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #3797 passed (37 minutes, 44 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #881 passed (1 minute, 41 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@markan markan deleted the ma/hab_7056/message_cleanup branch Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.