Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upadd windows system paths to environment PATH variable if included #7073
Conversation
|
Left a tiny suggestion you can take or leave, but |
| paths.push(PathBuf::from(str_sys_root)); | ||
| paths.push(system32.join("wbem")); | ||
| paths.push(system32.join("WindowsPowerShell").join("v1.0")); | ||
| } |
This comment has been minimized.
This comment has been minimized.
christophermaier
Oct 23, 2019
Contributor
Because Path and PathBuf can deal with OsStrs, you can simplify this a bit by getting rid of str_sys_root:
if let Some(sys_root) = env::var_os("SystemRoot") {
let system32 = Path::new(&sys_root).join("system32");
paths.push(system32.clone());
paths.push(PathBuf::from(sys_root));
paths.push(system32.join("wbem"));
paths.push(system32.join("WindowsPowerShell").join("v1.0"));
}Signed-off-by: mwrock <matt@mattwrock.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mwrock commentedOct 22, 2019
fixes #6657
On Windows these added paths are set by default on all modern windows systems. Any Windows application expects these paths to be present.
Signed-off-by: mwrock matt@mattwrock.com