Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Ensure version file can be properly sourced #7089

Merged
merged 1 commit into from Oct 23, 2019

Conversation

@christophermaier
Copy link
Contributor

christophermaier commented Oct 23, 2019

Rather than relying on BASH_SOURCE in a sourced file, we'll simply
ask git what our top-level directory is, and resolve our version
file from there.

Additionally, we'll create a temporary directory inside our current
directory, rather than /tmp, when generating our binary-only
artifacts. This keeps everything within the checkout directory.

Signed-off-by: Christopher Maier cmaier@chef.io

Rather than relying on `BASH_SOURCE` in a sourced file, we'll simply
ask `git` what our top-level directory is, and resolve our version
file from there.

Additionally, we'll create a temporary directory inside our current
directory, rather than `/tmp`, when generating our binary-only
artifacts. This keeps everything within the checkout directory.

Signed-off-by: Christopher Maier <cmaier@chef.io>
@christophermaier christophermaier requested a review from smacfarlane Oct 23, 2019
@christophermaier christophermaier self-assigned this Oct 23, 2019
@christophermaier christophermaier changed the title Ensure version file can be properly sourced [CI] Ensure version file can be properly sourced Oct 23, 2019
@christophermaier christophermaier merged commit 5130ea4 into master Oct 23, 2019
4 of 5 checks passed
4 of 5 checks passed
buildkite/habitat-sh-habitat-master-verify Build #3855 started
Details
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-website Build #936 passed (36 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@chef-expeditor chef-expeditor bot deleted the cm/fix-binary-packaging branch Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.