Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[CI] Ensure version file can be properly sourced #7089
Conversation
Rather than relying on `BASH_SOURCE` in a sourced file, we'll simply ask `git` what our top-level directory is, and resolve our version file from there. Additionally, we'll create a temporary directory inside our current directory, rather than `/tmp`, when generating our binary-only artifacts. This keeps everything within the checkout directory. Signed-off-by: Christopher Maier <cmaier@chef.io>
christophermaier
changed the title
christophermaier
merged commit 5130ea4
into
master
4 of 5 checks passed
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
christophermaier commentedOct 23, 2019
Rather than relying on
BASH_SOURCEin a sourced file, we'll simplyask
gitwhat our top-level directory is, and resolve our versionfile from there.
Additionally, we'll create a temporary directory inside our current
directory, rather than
/tmp, when generating our binary-onlyartifacts. This keeps everything within the checkout directory.
Signed-off-by: Christopher Maier cmaier@chef.io