Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop windows service if launcher exits #7099

Merged
merged 2 commits into from Oct 24, 2019
Merged

stop windows service if launcher exits #7099

merged 2 commits into from Oct 24, 2019

Conversation

@mwrock
Copy link
Contributor

mwrock commented Oct 23, 2019

fixes #6859

This ensures that if the launcher process exits for any reason, the windows service shuts itself down. It will not end up in a state where the service is in a running state but the supervisor is not running.

This also adds an install hook to the windows-service package to eliminate the need for the extra call to hab pkg exec core/windows-service install.

@mwrock mwrock force-pushed the win_service_exited branch from fc0f9f1 to 70596d4 Oct 24, 2019
@mwrock mwrock marked this pull request as ready for review Oct 24, 2019
@mwrock mwrock changed the title Win service exited stop windows service if launcher exits Oct 24, 2019
Copy link
Contributor

christophermaier left a comment

I'm no Windows expert, but this seems to make sense 😄

The "dev" -> "DEV" bit is the only real blocker here from my perspective.

.expeditor/end_to_end.pipeline.yml Outdated Show resolved Hide resolved
components/windows-service/hooks/install Show resolved Hide resolved
components/windows-service/plan.ps1 Show resolved Hide resolved

Describe "Bogus Launcher args" {
Stop-Service Habitat
(Get-Content c:/hab/svc/windows-service/HabService.dll.config).replace('--no-color', '--poop') |

This comment has been minimized.

Copy link
@christophermaier
mwrock added 2 commits Oct 24, 2019
Signed-off-by: mwrock <matt@mattwrock.com>
Signed-off-by: mwrock <matt@mattwrock.com>
@mwrock mwrock force-pushed the win_service_exited branch from 70596d4 to c2aef44 Oct 24, 2019
@mwrock mwrock merged commit afe6de1 into master Oct 24, 2019
5 checks passed
5 checks passed
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #3899 passed (32 minutes, 45 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #979 passed (37 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@mwrock mwrock deleted the win_service_exited branch Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.