Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Initial Expeditor Promotion trigger #7115

Merged
merged 3 commits into from Oct 28, 2019

Conversation

@christophermaier
Copy link
Contributor

christophermaier commented Oct 25, 2019

No description provided.

Signed-off-by: Christopher Maier <cmaier@chef.io>
@@ -95,3 +95,27 @@ schedules:
- name: cargo_update
description: "Run 'cargo update' every Monday at 12PM UTC"
cronline: "0 12 * * 1"

promote:
actions:

This comment has been minimized.

Copy link
@tduffield

tduffield Oct 25, 2019

So, I'm actually trying to deprecate this. Instead of this, please add the following to your subscriptions:

- workload: project_promoted:{{agent_id}}:current:*
  actions:
    - bash:.expeditor/scripts/expeditor_promote.sh
- workload: project_promoted:{{agent_id}}:stable:*
  actions:
    - bash:.expeditor/scripts/expeditor_promote.sh

This is a little bit clearer because it's declaring what you do want to happen, rather than what you don't.

This comment has been minimized.

Copy link
@christophermaier

christophermaier Oct 25, 2019

Author Contributor

Nice... the exclusions I was using felt a little odd; I much prefer this formulation!

This comment has been minimized.

Copy link
@christophermaier

christophermaier Oct 25, 2019

Author Contributor

@tduffield So the current and stable in the workload are destinations, and not sources?

Copy link
Contributor

scotthain left a comment

Other than Tom's comment - looks good. Going to link this issue for tracking purposes: https://github.com/habitat-sh/release-engineering/issues/85

This will let us start using our Slack promotion commands to promote
artifacts through the final, human-gated stages of our release
pipeline.

Right now, it just promotes packages, but eventually, we'll add
version bumping, Github release creation, release announcements,
etc. to this.

Signed-off-by: Christopher Maier <cmaier@chef.io>
Just to help keep things straight.

Signed-off-by: Christopher Maier <cmaier@chef.io>
@christophermaier christophermaier force-pushed the cm/promotion-triggers branch from 72bd641 to a53e91a Oct 25, 2019
@christophermaier christophermaier merged commit b4c0e10 into master Oct 28, 2019
5 checks passed
5 checks passed
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #3932 passed (46 minutes, 47 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #1012 passed (31 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@chef-expeditor chef-expeditor bot deleted the cm/promotion-triggers branch Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.