Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign uppoll for service startup in windows e2e tests #7123
Conversation
|
Looks like it'll do the trick. However, those timeouts seem really long (9x than the sleeps they replace!). Is that based on observation that they actually take that long, or are these just adding a lot of padding? Alternatively, if we're just testing loading, as opposed to "download and install if not present, and then load", we could just install the desired package before issuing |
This comment has been minimized.
This comment has been minimized.
|
It was just padding. But I like the "pre-install" strategy. Gonna go with that and use the polling function to wait just 5 seconds like before. |
mwrock
force-pushed the
test_timeout
branch
3 times, most recently
from
145d24d
to
33c7cb6
Signed-off-by: mwrock <matt@mattwrock.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mwrock commentedOct 28, 2019
Signed-off-by: mwrock matt@mattwrock.com