Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poll for service startup in windows e2e tests #7123

Merged
merged 1 commit into from Oct 28, 2019

Conversation

@mwrock
Copy link
Contributor

mwrock commented Oct 28, 2019

Signed-off-by: mwrock matt@mattwrock.com

@mwrock mwrock self-assigned this Oct 28, 2019
Copy link
Contributor

christophermaier left a comment

Looks like it'll do the trick.

However, those timeouts seem really long (9x than the sleeps they replace!). Is that based on observation that they actually take that long, or are these just adding a lot of padding?

Alternatively, if we're just testing loading, as opposed to "download and install if not present, and then load", we could just install the desired package before issuing hab svc load. I had to do this recently with another test.

@mwrock mwrock force-pushed the test_timeout branch from 8db65ca to 24b4730 Oct 28, 2019
@mwrock

This comment has been minimized.

Copy link
Contributor Author

mwrock commented Oct 28, 2019

It was just padding. But I like the "pre-install" strategy. Gonna go with that and use the polling function to wait just 5 seconds like before.

@mwrock mwrock force-pushed the test_timeout branch 3 times, most recently from 145d24d to 33c7cb6 Oct 28, 2019
Signed-off-by: mwrock <matt@mattwrock.com>
@mwrock mwrock force-pushed the test_timeout branch from 33c7cb6 to 66387f8 Oct 28, 2019
@mwrock mwrock merged commit 0873599 into master Oct 28, 2019
4 of 6 checks passed
4 of 6 checks passed
buildkite/habitat-sh-habitat-master-end-to-end Build #206 failed (5 minutes, 2 seconds)
Details
buildkite/habitat-sh-habitat-master-verify Build #3994 started
Details
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-website Build #1074 passed (39 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@mwrock mwrock deleted the test_timeout branch Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.