Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove IGNORE_SIGNALS feature #7140

Merged
merged 1 commit into from Nov 2, 2019

Conversation

@mwrock
Copy link
Contributor

mwrock commented Oct 31, 2019

resolves #5908

This also adds a e2e test to ensure a service's PID file is removed on shutdown which could not happen when the IGNORE_SIGNALS feature is enabled.

Signed-off-by: mwrock matt@mattwrock.com

Signed-off-by: mwrock <matt@mattwrock.com>
@mwrock mwrock self-assigned this Oct 31, 2019
@markan
markan approved these changes Nov 1, 2019
Copy link
Contributor

markan left a comment

Looks straightforward and reasonable. The question isn't a blocker, just for my education.

@@ -1006,18 +1006,12 @@ impl Manager {
break ShutdownMode::Departed;
}

// This formulation is gross, but it doesn't seem to compile on Windows otherwise.
#[allow(clippy::match_bool)]
#[allow(clippy::single_match)]
#[cfg(unix)]

This comment has been minimized.

Copy link
@markan

markan Nov 1, 2019

Contributor

Out of curiosity, is there no equivalent signal in windows? How does a windows service restart cleanly?

This comment has been minimized.

Copy link
@mwrock

mwrock Nov 1, 2019

Author Contributor

There really is no windows equivilent. The closest thing to a ubiquitous "restart me" signal would be a Windows Service restart but that only applies to programs running as windows services that must implement a specific interface with OnStart and OnStop methods. Outside of services apps typically handle this in app specific ways.

@mwrock mwrock merged commit 0719cbd into master Nov 2, 2019
5 checks passed
5 checks passed
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #4046 passed (20 minutes, 47 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #1125 passed (1 minute, 30 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@chef-expeditor chef-expeditor bot deleted the no_ignore_signals branch Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.