Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add Studio Image creation to release pipeline #7141

Merged
merged 1 commit into from Nov 5, 2019

Conversation

@christophermaier
Copy link
Contributor

christophermaier commented Nov 1, 2019

This basically copies over the existing code from the old pipeline to
the new pipeline, with minor tweaks as appropriate.

Signed-off-by: Christopher Maier cmaier@chef.io

@christophermaier christophermaier self-assigned this Nov 1, 2019
This basically copies over the existing code from the old pipeline to
the new pipeline, with minor tweaks as appropriate.

Signed-off-by: Christopher Maier <cmaier@chef.io>
@christophermaier christophermaier force-pushed the cm/release-docker-images branch from 6183c15 to 0fea733 Nov 5, 2019
@christophermaier christophermaier requested a review from mwrock Nov 5, 2019
Copy link
Contributor

scotthain left a comment

Looks like some inconsistency with prod vs acceptance bldr?

target="${BUILD_PKG_TARGET}"
image_name="habitat/default-studio-${target}"
image_name_with_tag="${image_name}:${version}"
bldr_url="${ACCEPTANCE_HAB_BLDR_URL}"

This comment has been minimized.

Copy link
@scotthain

scotthain Nov 5, 2019

Contributor

This one is acceptance...

Copy link
Contributor

smacfarlane left a comment

Looks good to me, outside of @scotthain questions. Based on slack discussions, I'm assuming that those are defaults vs overrides while we iterate on this in acceptance.

@mwrock
mwrock approved these changes Nov 5, 2019
@christophermaier christophermaier merged commit b1cd795 into master Nov 5, 2019
4 of 5 checks passed
4 of 5 checks passed
buildkite/habitat-sh-habitat-master-verify Build #4115 started
Details
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-website Build #1194 passed (46 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@chef-expeditor chef-expeditor bot deleted the cm/release-docker-images branch Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.