Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes docs update, removing references to the Operator and replacing with the Bastion pattern #7144

Merged
merged 3 commits into from Nov 8, 2019

Conversation

@irvingpop
Copy link
Contributor

irvingpop commented Nov 1, 2019

This PR reworks the Habitat docs regarding Kubernetes to reflect recent experiences in the field.

Signed-off-by: Irving Popovetsky irving@chef.io
Co-Authored-By: Kimberly Garmoe kgarmoe@chef.io

@chef-expeditor

This comment has been minimized.

Copy link

chef-expeditor bot commented Nov 1, 2019

Hello irvingpop! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

Copy link
Collaborator

kagarmoe left a comment

I have a PR in to hook up the /www/source/data directory and I will need to do some work to make the file appear in the correct place & provide a copy button/

www/source/docs/best-practices.html.md.erb Outdated Show resolved Hide resolved
www/source/docs/best-practices.html.md.erb Outdated Show resolved Hide resolved
www/source/docs/best-practices.html.md.erb Outdated Show resolved Hide resolved
www/source/docs/best-practices.html.md.erb Outdated Show resolved Hide resolved
www/source/docs/best-practices.html.md.erb Outdated Show resolved Hide resolved
www/source/docs/best-practices.html.md.erb Outdated Show resolved Hide resolved
www/source/docs/best-practices.html.md.erb Outdated Show resolved Hide resolved
www/source/docs/best-practices.html.md.erb Outdated Show resolved Hide resolved
www/source/docs/best-practices.html.md.erb Outdated Show resolved Hide resolved
www/source/docs/best-practices.html.md.erb Outdated Show resolved Hide resolved
@irvingpop

This comment has been minimized.

Copy link
Contributor Author

irvingpop commented Nov 1, 2019

I don't get what's making DCO bot mad - does it not like the Co-Authored-By: commits?

…cing with the Bastion pattern

Signed-off-by: Irving Popovetsky <irving@chef.io>
Co-Authored-By: Kimberly Garmoe <kgarmoe@chef.io>
@irvingpop irvingpop force-pushed the irvingpop:kube_docs_update_2 branch from ad05d9e to ca07838 Nov 1, 2019
@kagarmoe kagarmoe self-requested a review Nov 4, 2019
Copy link
Collaborator

kagarmoe left a comment

Re-thought how to use the example file in the docs.

Signed-off-by: Irving Popovetsky <irving@chef.io>
Copy link
Contributor

christophermaier left a comment

I have a few comments and questions, but nothing that would justify holding this kind of documentation back. I'm happy to see better docs for how to use Habitat with Kubernetes! Thanks @irvingpop !

I'll defer the final approval for @kagarmoe's feedback.

www/source/docs/best-practices.html.md.erb Outdated Show resolved Hide resolved
www/source/docs/best-practices.html.md.erb Outdated Show resolved Hide resolved
www/source/docs/best-practices.html.md.erb Outdated Show resolved Hide resolved
www/source/docs/best-practices.html.md.erb Outdated Show resolved Hide resolved
image: irvingpop/cockroach:latest
args:
- --peer
- hab-bastion

This comment has been minimized.

Copy link
@christophermaier

christophermaier Nov 6, 2019

Contributor

Does this end up working in practice when the bastion pod gets rescheduled? I don't think that DNS information persists within the system; it gets resolved to a concrete IP address early on, and that gets used thereafter.

This comment has been minimized.

Copy link
@irvingpop

irvingpop Nov 6, 2019

Author Contributor

the way I do it the DNS name maps to a service which acts as an LB, so it doesn't matter if the bastion pod itself gets rescheduled. in admittedly limited testing that seemed sane enough

This comment has been minimized.

Copy link
@christophermaier

christophermaier Nov 6, 2019

Contributor

🤔 I'm not sure what the underlying details of Kubernetes Service IP addressing are, but this might be worth keeping an eye on in the future.

Signed-off-by: Irving Popovetsky <irving@chef.io>
@christophermaier christophermaier merged commit 043f169 into habitat-sh:master Nov 8, 2019
5 checks passed
5 checks passed
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-verify Build #4122 passed (38 minutes, 9 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #1201 passed (43 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@irvingpop irvingpop deleted the irvingpop:kube_docs_update_2 branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.