Skip to content

/habitat

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Temporarily skip the bulkupload e2e test pending some refactoring #7168

Merged
merged 1 commit into from Nov 7, 2019

Conversation

@christophermaier
Copy link
Contributor

christophermaier commented Nov 7, 2019

This is solely to get the pipeline flowing again; a fix will be in later today.

Signed-off-by: Christopher Maier cmaier@chef.io
@christophermaier christophermaier requested a review from jeremymv2 Nov 7, 2019
@christophermaier christophermaier self-assigned this Nov 7, 2019
@jeremymv2
jeremymv2 approved these changes Nov 7, 2019
View changes
Copy link
Contributor

jeremymv2 left a comment

👍 👍 🌮
@smacfarlane
smacfarlane approved these changes Nov 7, 2019
View changes
Copy link
Contributor

smacfarlane left a comment •
edited

LGTM, though we may consider soft_fail as well so it continues to be angry-red at us.
https://buildkite.com/docs/pipelines/command-step
@christophermaier
Temporarily skip the bulkupload e2e test pending some refactoring
Loading status checks…
41375a3 
This is solely to get the pipeline flowing again; a fix will be in
later today.

Signed-off-by: Christopher Maier <cmaier@chef.io>
@christophermaier christophermaier force-pushed the cm/temporarily-disable-bulkupload-test branch from 502f06e to 41375a3 Nov 7, 2019
@christophermaier

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

christophermaier commented Nov 7, 2019

@smacfarlane 🤔 While I like the "angry red" aspect as a reminder, I was thinking of skip because it allows us to add metadata about why we're skipping. Also, I wasn't really thinking of this as a potentially flaky test, since this failure is really an aspect of how the test is integrated into the pipeline, rather than something in the logic of the tests per se.
@christophermaier christophermaier merged commit ae1192d into master Nov 7, 2019
5 of 6 checks passed
5 of 6 checks passed
buildkite/habitat-sh-habitat-master-verify Build #4143 started
Details
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-end-to-end Build #218 passed (14 minutes, 18 seconds)
Details
buildkite/habitat-sh-habitat-master-website Build #1222 passed (51 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@chef-expeditor chef-expeditor bot deleted the cm/temporarily-disable-bulkupload-test branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smacfarlane smacfarlane

@jeremymv2 jeremymv2

Assignees

@christophermaier christophermaier

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@christophermaier @smacfarlane @jeremymv2
You can’t perform that action at this time.