skip remote download when present in cache or offline #7915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeremy J. Miller <jm@chef.io>
jeremymv2
requested review from
christophermaier and
davidMcneil
as code owners
jeremymv2
changed the title
davidMcneil
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was present before but was unfortunately removed during a PR refactor here. I've audited the rest of the original PR and do not see any other occurrences of this problem.
This should fix the errors in our release pipeline where we are expecting to install artifacts from cache (fixture pkgs we built) but instead were attempting to download them: https://buildkite.com/chef/habitat-sh-habitat-master-end-to-end/builds/726#2ca1c095-0607-41e2-953f-f191553950f2
Signed-off-by: Jeremy J. Miller jm@chef.io