Skip to content
Sign up
This repository

public / Perlbal Octocat-spinner-32

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

Allow 0 as a HEADER ADD/SET value (Andreas Koenig) 

git-svn-id: http://code.sixapart.com/svn/perlbal/trunk@885 6caf28e9-730f-0410-b62b-a31386fe13fb
  • Loading branch information...
commit 12b6637aa3178d03de90b037eba26f0e0dc4ecaa 1 parent 6d3f00f
authored

Showing 3 changed files with 6 additions and 1 deletion. Show Diff Stats Hide Diff Stats

  1. 2  CHANGES
  2. 3  lib/Perlbal/Service.pm
  3. 2  t/15-webserver.t
2  CHANGES
View
... ... 
@@ -1,3 +1,5 @@
  1 
+    -- Allow "0" as a HEADER ADD/SET value (Andreas Koenig)
  2 
+
1 3 
     -- Cap our read buffers before AIO file operations to 1MB, this will prevent
2 4 
        memory over-use on systems with slow disks for PUT, or buffered upload temp
3 5 
        files. Assuming you system is fast enough to keep up with the writes this
3  lib/Perlbal/Service.pm
View 
@@ -1458,7 +1458,8 @@ sub header_management {
1458 1458 
     my Perlbal::Service $self = shift;
1459 1459 
     my ($mode, $key, $val, $mc) = @_;
1460 1460 
     return $mc->err("no header provided") unless $key;
1461   
-    return $mc->err("no value provided")  unless $val || $mode eq 'remove';
  1461 
+    return $mc->err("no value provided")  unless
  1462 
+        (defined $val && length $val || $mode eq 'remove');
1462 1463
1463 1464 
     if ($mode eq 'insert') {
1464 1465 
         push @{$self->{extra_headers}->{insert}}, [ $key, $val ];
2  t/15-webserver.t
View 
@@ -19,6 +19,8 @@ SET test.listen = 127.0.0.1:$port
19 19 
 SET test.docroot = $dir
20 20 
 SET test.dirindexing = 0
21 21 
 SET test.persist_client = 1
  22 
+HEADER test insert X-Good-Day: 1
  23 
+HEADER test insert X-Bad-Day: 0
22 24 
 ENABLE test
23 25 
 };
24 26

0 notes on commit 12b6637

Please sign in to comment.
Something went wrong with that request. Please try again.