Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create <TextField /> Component #32

Closed
tko22 opened this issue May 9, 2020 · 2 comments · Fixed by #60
Closed

Create <TextField /> Component #32

tko22 opened this issue May 9, 2020 · 2 comments · Fixed by #60
Assignees
Labels
component for component dev issues effort: high not spec'd issue is not fully fleshed out

Comments

@tko22
Copy link
Member

tko22 commented May 9, 2020

Design System Link

  • TextField
  • TextField.Label

image

Props

  • required: required, optional
  • helperText: str
  • autoComplete
  • aria-label
  • placeholder
  • icon?

more?

@tko22 tko22 added component for component dev issues not spec'd issue is not fully fleshed out labels May 9, 2020
@tko22 tko22 mentioned this issue May 9, 2020
7 tasks
@jackieo5023 jackieo5023 self-assigned this May 14, 2020
@jackieo5023
Copy link
Member

jackieo5023 commented May 15, 2020

I'm thinking this should also include:

  • disabled
  • error

We may want to consider proper validation later, either as part of a form component or within this component - ex. having a user define their own rules (like having a max length of 8 characters) and have the component trigger if it's valid or not, rather than the user writing this logic on their own.

I think we can also create a separate AutoComplete component rather than having it be a prop - similar to https://material-ui.com/components/autocomplete/ and https://ant.design/components/auto-complete/, where it's essentially a wrapper around other text input components.
I didn't know HTML inputs had their own autocomplete :O

@tko22
Copy link
Member Author

tko22 commented May 15, 2020

btw in form validation, I wouldn't worry about making the title red - it'll be changed in the design system soon.

I agree with disabled and error props and component trigger user-written rules. no worries if you can't do proper validation rn

Also, I'm thinking we create a Form Component that can encompass the differnet type of
Form inputs (this included) and then you would put the title.. so this one doesnt need to include title

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component for component dev issues effort: high not spec'd issue is not fully fleshed out
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants