Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added headerbar #11

Merged
merged 16 commits into from Oct 7, 2019

Conversation

@phntxx
Copy link
Contributor

commented Oct 1, 2019

Added headerbar as fix for issue #9

phntxx added 3 commits Oct 1, 2019
Added headerbar as fix for issue
Refactored dashboard.tsx to avoid conflicts with the dashboard-site
This reverts commit 8bfdc7a.
Copy link
Member

left a comment

This isn't used anywhere yet, right? Please utilise components when you introduce them.

frontend/src/config.ts Show resolved Hide resolved
frontend/src/components/dashboard.tsx Show resolved Hide resolved
phntxx added 5 commits Sep 27, 2019
Fixed headerbar so that it adjusts with the transition for sidebar-accessibility.
Copy link
Member

left a comment

Refactor LGTM, but please don't add unnecessary "clutter" to the PR (i.e. the new pages and react-table) when they're not "needed" yet.

frontend/src/components/users.tsx Outdated Show resolved Hide resolved
frontend/src/components/statistics.tsx Outdated Show resolved Hide resolved
frontend/src/index.html Outdated Show resolved Hide resolved
frontend/package.json Outdated Show resolved Hide resolved
frontend/package.json Outdated Show resolved Hide resolved
@codecov-io

This comment has been minimized.

Copy link

commented Oct 6, 2019

Codecov Report

Merging #11 into master will increase coverage by 0.03%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   71.85%   71.88%   +0.03%     
==========================================
  Files         119      120       +1     
  Lines        2043     2049       +6     
  Branches      322      323       +1     
==========================================
+ Hits         1468     1473       +5     
- Misses        575      576       +1
Flag Coverage Δ
#backend 80.31% <ø> (ø) ⬆️
#frontend 63.44% <81.81%> (+0.11%) ⬆️
Impacted Files Coverage Δ
frontend/src/routes.ts 100% <100%> (ø) ⬆️
frontend/src/config.ts 100% <100%> (ø) ⬆️
frontend/src/components/app.tsx 76.47% <100%> (ø) ⬆️
frontend/src/components/page-wrapper.tsx 76% <75%> (ø)
frontend/src/components/headerbar.tsx 75% <75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b4ea84...1ab79b5. Read the comment docs.

@michaelneu michaelneu force-pushed the phntxx:master branch from 2b3e108 to 1ab79b5 Oct 7, 2019
@michaelneu michaelneu merged commit 2cc1e19 into hackaburg:master Oct 7, 2019
2 checks passed
2 checks passed
ci/circleci: backend Your tests passed on CircleCI!
Details
ci/circleci: frontend Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.