Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake8 Cleanup and Praying I didn't break anything #62

Merged
merged 7 commits into from Sep 3, 2016

Conversation

@hpincket
Copy link
Collaborator

hpincket commented Sep 1, 2016

Lots and lots of changes.

@hpincket hpincket referenced this pull request Sep 1, 2016
@hpincket

This comment has been minimized.

Copy link
Collaborator Author

hpincket commented Sep 1, 2016

All the above says is that our code is Flake8 compliant.

@joengelm joengelm merged commit ad31917 into hackatbrown:master Sep 3, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
joengelm added a commit that referenced this pull request Sep 3, 2016
This reverts commit ad31917, reversing
changes made to b8fd0e4.
@joengelm

This comment has been minimized.

Copy link
Member

joengelm commented Sep 3, 2016

@hpincket Sorry, I merged that too soon (and have now reverted it). I think this will introduce Python errors because of the way the imports have been rearranged. Can you try running this locally, fix any errors (or confirm that there are none), and put up a new PR?

@joengelm

This comment has been minimized.

Copy link
Member

joengelm commented Sep 3, 2016

For reference, this is the error that occurred on our server after merging your changes and rebuilding:

Sep 02 18:53:02 brown-apis app/web.1:  Traceback (most recent call last):
Sep 02 18:53:02 brown-apis app/web.1:    File "/app/.heroku/python/lib/python3.4/site-packages/gunicorn/arbiter.py", line 507, in spawn_worker 
Sep 02 18:53:02 brown-apis app/web.1:      worker.init_process() 
Sep 02 18:53:02 brown-apis app/web.1:    File "/app/.heroku/python/lib/python3.4/site-packages/gunicorn/workers/base.py", line 118, in init_process 
Sep 02 18:53:02 brown-apis app/web.1:      self.wsgi = self.app.wsgi() 
Sep 02 18:53:02 brown-apis app/web.1:    File "/app/.heroku/python/lib/python3.4/site-packages/gunicorn/app/base.py", line 67, in wsgi 
Sep 02 18:53:02 brown-apis app/web.1:      self.callable = self.load() 
Sep 02 18:53:02 brown-apis app/web.1:    File "/app/.heroku/python/lib/python3.4/site-packages/gunicorn/app/wsgiapp.py", line 65, in load 
Sep 02 18:53:02 brown-apis app/web.1:      return self.load_wsgiapp() 
Sep 02 18:53:02 brown-apis app/web.1:    File "/app/.heroku/python/lib/python3.4/site-packages/gunicorn/app/wsgiapp.py", line 52, in load_wsgiapp 
Sep 02 18:53:02 brown-apis app/web.1:      return util.import_app(self.app_uri) 
Sep 02 18:53:02 brown-apis app/web.1:    File "/app/.heroku/python/lib/python3.4/site-packages/gunicorn/util.py", line 355, in import_app 
Sep 02 18:53:02 brown-apis app/web.1:      __import__(module) 
Sep 02 18:53:02 brown-apis app/web.1:    File "/app/api/__init__.py", line 7, in <module> 
Sep 02 18:53:02 brown-apis app/web.1:      import api.meta 
Sep 02 18:53:02 brown-apis app/web.1:    File "/app/api/meta.py", line 4, in <module> 
Sep 02 18:53:02 brown-apis app/web.1:      from api import app, db, requires_auth, make_json_error 
Sep 02 18:53:02 brown-apis app/web.1:  ImportError: cannot import name 'app' 
@hpincket

This comment has been minimized.

Copy link
Collaborator Author

hpincket commented Sep 3, 2016

I remember this case in the code. Ill fix it tomorrow.

And yes, I was putting off figuring out how to set it all up. Will do that too.

On September 2, 2016 7:03:40 PM PDT, Joe Engelman notifications@github.com wrote:

For reference, this is the error that occurred on our server after
merging your changes and rebuilding:

Sep 02 18:53:02 brown-apis app/web.1:  Traceback (most recent call
last):
Sep 02 18:53:02 brown-apis app/web.1:    File
"/app/.heroku/python/lib/python3.4/site-packages/gunicorn/arbiter.py",
line 507, in spawn_worker 
Sep 02 18:53:02 brown-apis app/web.1:      worker.init_process() 
Sep 02 18:53:02 brown-apis app/web.1:    File
"/app/.heroku/python/lib/python3.4/site-packages/gunicorn/workers/base.py",
line 118, in init_process 
Sep 02 18:53:02 brown-apis app/web.1:      self.wsgi = self.app.wsgi() 
Sep 02 18:53:02 brown-apis app/web.1:    File
"/app/.heroku/python/lib/python3.4/site-packages/gunicorn/app/base.py",
line 67, in wsgi 
Sep 02 18:53:02 brown-apis app/web.1:      self.callable = self.load() 
Sep 02 18:53:02 brown-apis app/web.1:    File
"/app/.heroku/python/lib/python3.4/site-packages/gunicorn/app/wsgiapp.py",
line 65, in load 
Sep 02 18:53:02 brown-apis app/web.1:      return self.load_wsgiapp() 
Sep 02 18:53:02 brown-apis app/web.1:    File
"/app/.heroku/python/lib/python3.4/site-packages/gunicorn/app/wsgiapp.py",
line 52, in load_wsgiapp 
Sep 02 18:53:02 brown-apis app/web.1:      return
util.import_app(self.app_uri) 
Sep 02 18:53:02 brown-apis app/web.1:    File
"/app/.heroku/python/lib/python3.4/site-packages/gunicorn/util.py",
line 355, in import_app 
Sep 02 18:53:02 brown-apis app/web.1:      __import__(module) 
Sep 02 18:53:02 brown-apis app/web.1:    File "/app/api/__init__.py",
line 7, in <module> 
Sep 02 18:53:02 brown-apis app/web.1:      import api.meta 
Sep 02 18:53:02 brown-apis app/web.1:    File "/app/api/meta.py", line
4, in <module> 
Sep 02 18:53:02 brown-apis app/web.1:      from api import app, db,
requires_auth, make_json_error 
Sep 02 18:53:02 brown-apis app/web.1:  ImportError: cannot import name
'app' 

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#62 (comment)

Sent from my Android device with K-9 Mail. Please excuse my brevity.

@hpincket

This comment has been minimized.

Copy link
Collaborator Author

hpincket commented Sep 6, 2016

I have a possible fix for this. It starts up, but I'm not sure if it will break farther down some code path.

@joengelm

This comment has been minimized.

Copy link
Member

joengelm commented Sep 19, 2016

Can you put up the fix in a new PR?

hpincket added a commit to hpincket/apis that referenced this pull request Sep 20, 2016
In which harrison reverts joe's revert so that the merge is better.

This reverts commit ee7b1dd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.