Add ratelimiting #37
Merged
Add ratelimiting #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds rate limiting to the API using SlowAPI with Redis as the storage backend. The implementation protects authentication endpoints (OTP send/validate) and expensive external API operations (Hackatime integrations) from abuse while maintaining a reasonable default limit for all other endpoints.
Key changes:
- Created centralized rate limiting configuration in
lib/ratelimiting.pywith Redis storage - Integrated SlowAPI middleware and exception handling into the FastAPI application
- Applied strict rate limits (5/hour) to OTP authentication endpoints
- Applied moderate rate limits (5/minute) to Hackatime integration endpoints
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
lib/ratelimiting.py |
New module defining rate limiter configuration with Redis backend, default 120 requests/minute |
main.py |
Integrated SlowAPI middleware, exception handler, and limiter into FastAPI app; improved import organization |
api/v1/auth/main.py |
Applied 5/hour rate limits to OTP send and validate endpoints |
api/v1/users/main.py |
Applied 5/minute rate limits to Hackatime time recalculation and account linking retry endpoints |
api/v1/projects/main.py |
Applied 5/minute rate limits to Hackatime project link/unlink endpoints |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.