Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add application json notifier #406

Merged
merged 3 commits into from May 17, 2019

Conversation

Projects
None yet
2 participants
@MaxWofford
Copy link
Member

commented May 7, 2019

No description provided.

@MaxWofford MaxWofford force-pushed the applications-to-airtable branch from 84aac0f to 8ac215d May 8, 2019

@MaxWofford

This comment has been minimized.

Copy link
Member Author

commented May 8, 2019

@zachlatta ready for your review

Tested using mailer preview. Screenshot below is a result (w/ fake applicant info):

Screen Shot 2019-05-07 at 8 20 44 PM

@MaxWofford MaxWofford requested a review from zachlatta May 8, 2019

@zachlatta

This comment has been minimized.

Copy link
Member

commented May 16, 2019

Hey, we need tests on this as this is a fully tested codebase. I don't want to break that assumption now.

Let's block 30m tomorrow to work through this together. Please send a calendar invite- would be great if we could get it in before noon.

@MaxWofford

This comment has been minimized.

Copy link
Member Author

commented May 17, 2019

Just reviewed in person with @zachlatta & have permission to merge

@MaxWofford MaxWofford merged commit 15eb5e4 into master May 17, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.