Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Logging To Mac For "Setting Actions" #134

Merged
merged 1 commit into from Jul 3, 2023
Merged

Conversation

sampoder
Copy link
Member

This uses info from the log package.

@sampoder sampoder changed the title Add Logging To Mac "Setting Actions" Add Logging To Mac For "Setting Actions" Jun 29, 2023
@conradev
Copy link
Collaborator

conradev commented Jul 1, 2023

re, the message, can we fix it?

Add Logging To Mac "Setting Actions"
This uses info from the log package.

Commit titles should be not be title-cased (they should be sentence-cased) and "Setting Actions" is unclear. Perhaps:

Log when TunInterface is configured
  • Specifies which part of the code this affects. You and I have the context that this affects TunInterface, but a future engineer would not
  • Active verb of what the code does is better than a passive verb of what you are doing (Log vs Add Logging)

Good commit messages are important. They do not matter at all when working locally, but they matter a lot once the code is merged.

@conradev conradev added this to the Functioning network tunnel milestone Jul 1, 2023
This uses info from the log package.
@conradev conradev enabled auto-merge (rebase) July 3, 2023 13:33
@conradev conradev merged commit 9eb661e into main Jul 3, 2023
8 checks passed
@conradev conradev deleted the add-logging-to-mac branch July 3, 2023 13:39
@sampoder
Copy link
Member Author

sampoder commented Jul 3, 2023

My bad re: commit message, sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants