Use tracing for logging #141
Conversation
burrow/src/main.rs
Outdated
|
|
||
| #[cfg(target_os = "linux")] | ||
| fn init_logger_layer() -> tracing_journald::Layer { | ||
| tracing_journald::layer().expect("Couldn't open journald socket - are you using systemd?").with_syslog_identifier("burrow".to_string()) |
There was a problem hiding this comment.
We should not crash if the user doesn't have journald installed on Linux. Further, we should fail silently if the error is an io::ErrorKind::NotFound (and I'd ask that we test that on a system without journald, if possible), but log the error if it is anything else. We don't want to spam the log for users that don't use journald.
also, can
There was a problem hiding this comment.
done - although I don't have a system/vm without journald available right now so I added a trace level log for later testing (it won't show up unless the RUST_LOG env variable is changed)
|
also, I can test on macOS! |
I'm not too familiar with git so I'm not sure how to do that - github says the repo owner has to enable it because the option is grayed out for me |
This commit replaces the log crate and the env_logger backend with a newer tokio tracing framework. This framework allows logging spans in adddition to messages.
|
A git rebase is something you do locally, and is just a way of editing your commits. You'll have to do it locally, because Github doesn't help with it I can show you how to do it when I get a chance, but also I squashed your commits for you in this case, so we should be good to merge |
|
@Dev380 it looks like the builds are failing, though! You can ignore the "Apple Build" ones (which won't work because this is a PR from a fork and not a branch), but we need to fix the Rust Build errors |
|
It looks like tracing-oslog is broken on some versions of Rust/macOS, which I might need to help with: It also looks like we need a manual Linux looks like a typo |
|
Update: good to go, failing CI and merge conflicts |
Attempts progress on #125
Currently, this PR switches logging to the tracing crate, and uses system loggers and tracing's stdout logger on mac and linux. I'm unable to test if it actually works on mac because I don't have access to one. Additionally, everything is instrumented with the #[instrument] macro so we have spans for free. Haven't figured out how to log to a system log storage yet on windows, and the linux implementation depends on systemd existing. Adding more logging to tun still needs to be completed.