Skip to content

Events can't run past midight #12

Closed
dustball opened this Issue Jan 27, 2011 · 4 comments

3 participants

@dustball

Events can't cross the date boundary.

DESIGN NEEDED on this. Discussion is needed to identify the exact behavior we desire. Would we change Date to Start Date and End Date? That would have a lot of other repercussions, for example, the code that lists events would need to know how to render multiple day events specially. (And I can't even think of a good way to do it that works for "normal" multi-day events, and ones that just go a few hours after midnight, for example).

@mikeharris100 mikeharris100 added a commit to mikeharris100/hd-events that referenced this issue Dec 2, 2011
@mikeharris100 mikeharris100 (For #12) Added basic ability to add/edit/view end *date* of an event
Swapped out "Date, Start Time, End Time" pattern for "Start Date/Time,
End Date/Time" on new, confirmation, edit and event view pages.
c6a3cce
@mikeharris100

Basic add/edit/view done. Although theres no validation to ensure your event doesn't end before it starts or anything like that. With regard to the event list: how about if an event that started before today but continues past 9am (or some other time) today, then that event gets listed today as well, with some clear indication thats it's a continued event?

@dustball
dustball commented Dec 2, 2011

Nice work. Yes, I think that would be a good idea. Might use 8AM, and just repeat the event with "(contd)" at the end of the title?

Should test this so it works even if the start date has passed (i.e., the "contd" event still shows up even for "today").

@dustball
dustball commented Dec 3, 2011

Also, with javascript: When selecting a start date, that date should be copied into the end date field automatically (if the end date field is blank).

@mikeharris100 mikeharris100 added a commit to mikeharris100/hd-events that referenced this issue Dec 5, 2011
@mikeharris100 mikeharris100 (For #12) Autofill end_date on new event page 1ad395b
@mikeharris100 mikeharris100 added a commit to mikeharris100/hd-events that referenced this issue Dec 5, 2011
@mikeharris100 mikeharris100 (For #12) Show every day of multiple day events 411c89f
@mikeharris100

Right, that should do the trick. It's a bit of a hack so I won't be offended if you rip it to shreds. Has been not-very-thoroughly tested for these situations:

Events that span multiple days have a listing for each day they run
Events that run past midnight but finish before 8am are not listed on that day
Events that start after midnight but finish before 8am today are not borked by the above
Events that started before today but end today or later will only have their today/future dates listed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.