Skip to content

Hacketyhack may now start without an internet connection #142

Merged
merged 1 commit into from Jan 1, 2012

2 participants

@PragTob
Hackety Hack member
PragTob commented Dec 31, 2011

hacketyhack does not crash any more when starting without an Internet connection. The only place where I had to check for this was the check for the latest version.

In order to determine whether we have a connection or not an HTTP request to the hacketyhack API is made in order to see whether the response is a HTTP Success.

I went with this approach rather than just rescuing the error, because the same function could be used to deactivate other Internet related functionality (Register a new account, Upload button of the editor).

This should close issue #140 (is there a way to get this pull request directly into this issue?)

@PragTob PragTob hacketyhack does not crash anymore when starting without an internet …
…connection. in order to determine whether we hace a connection or not an HTTP request to the hacketyhack API is made in order to see whether the response is a HTTP Success
be4e7b4
@steveklabnik steveklabnik merged commit 3f714ff into hacketyhack:master Jan 1, 2012
@steveklabnik
Hackety Hack member

Awesome, thanks!

(is there a way to get this pull request directly into this issue?)

Nope. You can say "Closes #140" in the commit message and it'll close the related issue though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.