Update the home icon with a pin icon 1905#1959
Merged
rayneng merged 4 commits intoMay 9, 2025
Merged
Conversation
DrAcula27
approved these changes
May 8, 2025
Member
DrAcula27
left a comment
DrAcula27
left a comment
There was a problem hiding this comment.
@DorianDeptuch Great job on your issue! Your code passed the ABC's, including:
- PR is made from the correct branch
- PR links to the correct issue:
- The correct files
assets/address-icon-48.svg&components/Map/layers/AddressLayer.jswere edited - The correct colors were used
- No unnecessary extra edits were made
- Appearance of the website is otherwise unchanged (Chrome and Firefox)
Below are screenshots I took of the pin in both hover and non-hover states for addresses that are within and outside NC boundaries:
- Pin Outside NC Boundaries - Non-Hover:
- Pin Outside NC Boundaries - Hover:
- Pin Inside an NC Boundary - Non-Hover:
- Pin Inside an NC Boundary - Hover:
Approved! 👍
rayneng
approved these changes
May 9, 2025
Member
rayneng
left a comment
rayneng
left a comment
There was a problem hiding this comment.
Tested locally, changes are looking good 👍 Merging now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1905
mainbranchAny questions? See the getting started guide
Before screenshot: Home Icon
After screenshot: Address Icon w/out Hover
After screenshot: Address Icon w/ Hover