Develop #225
Merged
Develop #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/215 get stats
Fix crucial bug, add additional search feature
* Fix mention of docs to reflect new docs address * version 1.1.0 * version 1.1.1 * allow booleanValidator to take comparator value for codeOfConduct * Create tests for false codeOfConduct in hacker * Move success messages to constants file * add missing success message
* Fix mention of docs to reflect new docs address * version 1.1.0 * version 1.1.1 * allow booleanValidator to take comparator value for codeOfConduct * Create tests for false codeOfConduct in hacker
krubenok
requested review from
YiFeiZhang2,
pashakondratyev and
pierreTklein
pierreTklein
approved these changes
Dec 21, 2018
pierreTklein
added a commit
that referenced
this pull request
Jan 9, 2019
* WIP role create route * Change role service async calls to be in line with other services * Write stats route * Update docs * Add tests * Add role to vs code debugger * Add role services * Fix false async * create role middleware * role error constants and add to app.js * create role controller * WIP role route and role route tests * Fix crucial bug, add additional search feature * Update documentation * Make test more descriptive * Move variable to constants file * create /api/role/ route * Add success constants * Add tests * Fix validator logic * fix bugs with services with missing await * comenting and documentation * Constants/successes (#213) * Fix mention of docs to reflect new docs address * version 1.1.0 * version 1.1.1 * allow booleanValidator to take comparator value for codeOfConduct * Create tests for false codeOfConduct in hacker * Move success messages to constants file * add missing success message * Add comments, change tests a little * Remove duplicate check * Fix develop (#223) * Fix mention of docs to reflect new docs address * version 1.1.0 * version 1.1.1 * allow booleanValidator to take comparator value for codeOfConduct * Create tests for false codeOfConduct in hacker * Separate account read into controller and middleware * Move findbyid into middleware * Separate sponsor controller in to middleware and controller * Split team into middleware * Split volunteer creation into middleware and controller * Fix tests * Add teamId to hacker * Combine name and pronoun validators with duplicate logic into ascii validator * change all name and pronoun validator to ascii validator * Merge validations * Update parsehacker to include teamId * Create checks for team size for update * WIP join team route * Controller and WIP tests * remove async, make devpost optional * Fix typos and merge constants * wip auth * switch names to success.constant * wip tests * Bump winston from 2.4.2 to 2.4.4 Bumps [winston](https://github.com/winstonjs/winston) from 2.4.2 to 2.4.4. - [Release notes](https://github.com/winstonjs/winston/releases) - [Changelog](https://github.com/winstonjs/winston/blob/2.4.4/CHANGELOG.md) - [Commits](winstonjs/winston@2.4.2...2.4.4) Signed-off-by: dependabot[bot] <support@dependabot.com> * Bump jshint from 2.9.6 to 2.9.7 Bumps [jshint](https://github.com/jshint/jshint) from 2.9.6 to 2.9.7. - [Release notes](https://github.com/jshint/jshint/releases) - [Changelog](https://github.com/jshint/jshint/blob/master/CHANGELOG.md) - [Commits](jshint/jshint@2.9.6...2.9.7) Signed-off-by: dependabot[bot] <support@dependabot.com> * Bump express-validator from 5.2.0 to 5.3.1 Bumps [express-validator](https://github.com/express-validator/express-validator) from 5.2.0 to 5.3.1. - [Release notes](https://github.com/express-validator/express-validator/releases) - [Commits](express-validator/express-validator@v5.2.0...v5.3.1) Signed-off-by: dependabot[bot] <support@dependabot.com> * Bump chai from 4.1.2 to 4.2.0 Bumps [chai](https://github.com/chaijs/chai) from 4.1.2 to 4.2.0. - [Release notes](https://github.com/chaijs/chai/releases) - [Changelog](https://github.com/chaijs/chai/blob/master/History.md) - [Commits](chaijs/chai@4.1.2...4.2.0) Signed-off-by: dependabot[bot] <support@dependabot.com> * Bump express-winston from 2.5.1 to 2.6.0 Bumps [express-winston](https://github.com/bithavoc/express-winston) from 2.5.1 to 2.6.0. - [Release notes](https://github.com/bithavoc/express-winston/releases) - [Changelog](https://github.com/bithavoc/express-winston/blob/master/CHANGELOG.md) - [Commits](https://github.com/bithavoc/express-winston/commits/v2.6.0) Signed-off-by: dependabot[bot] <support@dependabot.com> * Bump @types/mongoose from 5.0.13 to 5.3.5 Bumps [@types/mongoose](https://github.com/DefinitelyTyped/DefinitelyTyped) from 5.0.13 to 5.3.5. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits) Signed-off-by: dependabot[bot] <support@dependabot.com> * Bump @types/google-cloud__storage from 1.7.1 to 1.7.2 Bumps [@types/google-cloud__storage](https://github.com/DefinitelyTyped/DefinitelyTyped) from 1.7.1 to 1.7.2. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits) Signed-off-by: dependabot[bot] <support@dependabot.com> * Bump apidoc from 0.17.6 to 0.17.7 Bumps [apidoc](https://github.com/apidoc/apidoc) from 0.17.6 to 0.17.7. - [Release notes](https://github.com/apidoc/apidoc/releases) - [Changelog](https://github.com/apidoc/apidoc/blob/master/CHANGELOG.md) - [Commits](https://github.com/apidoc/apidoc/commits) Signed-off-by: dependabot[bot] <support@dependabot.com> * Bump cors from 2.8.4 to 2.8.5 Bumps [cors](https://github.com/expressjs/cors) from 2.8.4 to 2.8.5. - [Release notes](https://github.com/expressjs/cors/releases) - [Changelog](https://github.com/expressjs/cors/blob/master/HISTORY.md) - [Commits](expressjs/cors@v2.8.4...v2.8.5) Signed-off-by: dependabot[bot] <support@dependabot.com> * Bump @types/mongodb from 3.0.18 to 3.1.18 Bumps [@types/mongodb](https://github.com/DefinitelyTyped/DefinitelyTyped) from 3.0.18 to 3.1.18. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits) Signed-off-by: dependabot[bot] <support@dependabot.com> * More test cases * Bump mongoose from 5.1.0 to 5.4.1 Bumps [mongoose](https://github.com/Automattic/mongoose) from 5.1.0 to 5.4.1. - [Release notes](https://github.com/Automattic/mongoose/releases) - [Changelog](https://github.com/Automattic/mongoose/blob/master/History.md) - [Commits](Automattic/mongoose@5.1.0...5.4.1) Signed-off-by: dependabot[bot] <support@dependabot.com> * update npm packages * Fix typo * Fix typos and make sure tests work * Add documentation and comments * remove WIP material * Remove debug constants * Change team services to also update hacker * Bump dotenv from 5.0.1 to 6.2.0 (#240) Bumps [dotenv](https://github.com/motdotla/dotenv) from 5.0.1 to 6.2.0. - [Release notes](https://github.com/motdotla/dotenv/releases) - [Changelog](https://github.com/motdotla/dotenv/blob/master/CHANGELOG.md) - [Commits](motdotla/dotenv@v5.0.1...v6.2.0) Signed-off-by: dependabot[bot] <support@dependabot.com> * Update regex pattern * change to enum validation (#259) * Revert "Bump jsonwebtoken from 8.3.0 to 8.4.0" This reverts commit e1cb108. * Revert "Bump bcrypt from 3.0.0 to 3.0.3" This reverts commit e40d783. * Revert "Bump @google-cloud/storage from 2.3.1 to 2.3.4" This reverts commit 1b4c8a2. * Revert "Bump nodemon from 1.17.3 to 1.18.9" This reverts commit 8b09373. * Revert "Bump @types/express from 4.11.1 to 4.16.0" This reverts commit 24f564e. * Revert "Bump multer from 1.3.1 to 1.4.1" This reverts commit c05f136. * Revert "Bump express from 4.16.3 to 4.16.4" This reverts commit d9ce20d. * Revert "Bump chai-http from 4.0.0 to 4.2.0" This reverts commit fc1f73d. * Revert "version 1.1.2" This reverts commit 4c81019. * Revert "Develop (#225)" This reverts commit 24a2748. * Bump chai-http from 4.0.0 to 4.2.1 Bumps [chai-http](https://github.com/chaijs/chai-http) from 4.0.0 to 4.2.1. - [Release notes](https://github.com/chaijs/chai-http/releases) - [Changelog](https://github.com/chaijs/chai-http/blob/master/History.md) - [Commits](chaijs/chai-http@4.0.0...4.2.1) Signed-off-by: dependabot[bot] <support@dependabot.com> * Bump @types/mongoose from 5.3.5 to 5.3.6 Bumps [@types/mongoose](https://github.com/DefinitelyTyped/DefinitelyTyped) from 5.3.5 to 5.3.6. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits) Signed-off-by: dependabot[bot] <support@dependabot.com> * change errors * Bump mongoose from 5.4.1 to 5.4.2 Bumps [mongoose](https://github.com/Automattic/mongoose) from 5.4.1 to 5.4.2. - [Release notes](https://github.com/Automattic/mongoose/releases) - [Changelog](https://github.com/Automattic/mongoose/blob/master/History.md) - [Commits](Automattic/mongoose@5.4.1...5.4.2) Signed-off-by: dependabot[bot] <support@dependabot.com> * Bump @types/mongoose from 5.3.6 to 5.3.7 Bumps [@types/mongoose](https://github.com/DefinitelyTyped/DefinitelyTyped) from 5.3.6 to 5.3.7. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits) Signed-off-by: dependabot[bot] <support@dependabot.com> * Make projectName optional * add next * Fix bug where new Team validator looked for name, not teamName * Update docs * Change all instances of teamName to name * Add check for hacker joining same team * comments * Make more items editable (#269) * Make more items editable * Update docs * Add flags to mongoose connection (#272) * Add invite route (#252) * Add invite route * Documentation * Feature/team get (#270) * Add routes and roles * add showTeam with member names * create tests * Create middleware to display member names and add auth * documentation and function commenting * add some more test details * docs and typo * Change findMemberNames to use Mongoose.populate * Change documentation to so param type is ObjectId * Move id for get to be in req.param * Fix documentation, make test cases more detailed * Feature/team post (#273) * change to enum validation * Add authentication to team create * Create team * Add tests for team * WIP team post duplication issue * Add check for duplicate team name, and test for hacker already being in a team * uncomment tests * fix git merge mistake * Remove testing code, make sure create also updates hacker * docs * Remove test index * re-add index on team name * fix merge issue * Feature/274 stats query (#275) * Add query param to stats * Docs * Fix test * Feature/278 team leave (#279) * Add route * Change success name, add tests * Fix api_data * Add removeTeamIfEmpty * Add leave to hackerRole * Bug fix * General team bugfixes * fn name change * Remove console.log * Change function name * Feature/team patch (#277) * WIP team patch * WIP team patch * docs and tests * fix merge issue * WIP patch * Commenting, fix parsePatch, remove unused function * PR comments * Description and errors * Fix bracket issue * Change link (#282)
pierreTklein
added a commit
that referenced
this pull request
Jan 13, 2019
* WIP role create route * Change role service async calls to be in line with other services * Write stats route * Update docs * Add tests * Add role to vs code debugger * Add role services * Fix false async * create role middleware * role error constants and add to app.js * create role controller * WIP role route and role route tests * Fix crucial bug, add additional search feature * Update documentation * Make test more descriptive * Move variable to constants file * create /api/role/ route * Add success constants * Add tests * Fix validator logic * fix bugs with services with missing await * comenting and documentation * Constants/successes (#213) * Fix mention of docs to reflect new docs address * version 1.1.0 * version 1.1.1 * allow booleanValidator to take comparator value for codeOfConduct * Create tests for false codeOfConduct in hacker * Move success messages to constants file * add missing success message * Add comments, change tests a little * Remove duplicate check * Fix develop (#223) * Fix mention of docs to reflect new docs address * version 1.1.0 * version 1.1.1 * allow booleanValidator to take comparator value for codeOfConduct * Create tests for false codeOfConduct in hacker * Separate account read into controller and middleware * Move findbyid into middleware * Separate sponsor controller in to middleware and controller * Split team into middleware * Split volunteer creation into middleware and controller * Fix tests * Add teamId to hacker * Combine name and pronoun validators with duplicate logic into ascii validator * change all name and pronoun validator to ascii validator * Merge validations * Update parsehacker to include teamId * Create checks for team size for update * WIP join team route * Controller and WIP tests * remove async, make devpost optional * Fix typos and merge constants * wip auth * switch names to success.constant * wip tests * Bump winston from 2.4.2 to 2.4.4 Bumps [winston](https://github.com/winstonjs/winston) from 2.4.2 to 2.4.4. - [Release notes](https://github.com/winstonjs/winston/releases) - [Changelog](https://github.com/winstonjs/winston/blob/2.4.4/CHANGELOG.md) - [Commits](winstonjs/winston@2.4.2...2.4.4) Signed-off-by: dependabot[bot] <support@dependabot.com> * Bump jshint from 2.9.6 to 2.9.7 Bumps [jshint](https://github.com/jshint/jshint) from 2.9.6 to 2.9.7. - [Release notes](https://github.com/jshint/jshint/releases) - [Changelog](https://github.com/jshint/jshint/blob/master/CHANGELOG.md) - [Commits](jshint/jshint@2.9.6...2.9.7) Signed-off-by: dependabot[bot] <support@dependabot.com> * Bump express-validator from 5.2.0 to 5.3.1 Bumps [express-validator](https://github.com/express-validator/express-validator) from 5.2.0 to 5.3.1. - [Release notes](https://github.com/express-validator/express-validator/releases) - [Commits](express-validator/express-validator@v5.2.0...v5.3.1) Signed-off-by: dependabot[bot] <support@dependabot.com> * Bump chai from 4.1.2 to 4.2.0 Bumps [chai](https://github.com/chaijs/chai) from 4.1.2 to 4.2.0. - [Release notes](https://github.com/chaijs/chai/releases) - [Changelog](https://github.com/chaijs/chai/blob/master/History.md) - [Commits](chaijs/chai@4.1.2...4.2.0) Signed-off-by: dependabot[bot] <support@dependabot.com> * Bump express-winston from 2.5.1 to 2.6.0 Bumps [express-winston](https://github.com/bithavoc/express-winston) from 2.5.1 to 2.6.0. - [Release notes](https://github.com/bithavoc/express-winston/releases) - [Changelog](https://github.com/bithavoc/express-winston/blob/master/CHANGELOG.md) - [Commits](https://github.com/bithavoc/express-winston/commits/v2.6.0) Signed-off-by: dependabot[bot] <support@dependabot.com> * Bump @types/mongoose from 5.0.13 to 5.3.5 Bumps [@types/mongoose](https://github.com/DefinitelyTyped/DefinitelyTyped) from 5.0.13 to 5.3.5. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits) Signed-off-by: dependabot[bot] <support@dependabot.com> * Bump @types/google-cloud__storage from 1.7.1 to 1.7.2 Bumps [@types/google-cloud__storage](https://github.com/DefinitelyTyped/DefinitelyTyped) from 1.7.1 to 1.7.2. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits) Signed-off-by: dependabot[bot] <support@dependabot.com> * Bump apidoc from 0.17.6 to 0.17.7 Bumps [apidoc](https://github.com/apidoc/apidoc) from 0.17.6 to 0.17.7. - [Release notes](https://github.com/apidoc/apidoc/releases) - [Changelog](https://github.com/apidoc/apidoc/blob/master/CHANGELOG.md) - [Commits](https://github.com/apidoc/apidoc/commits) Signed-off-by: dependabot[bot] <support@dependabot.com> * Bump cors from 2.8.4 to 2.8.5 Bumps [cors](https://github.com/expressjs/cors) from 2.8.4 to 2.8.5. - [Release notes](https://github.com/expressjs/cors/releases) - [Changelog](https://github.com/expressjs/cors/blob/master/HISTORY.md) - [Commits](expressjs/cors@v2.8.4...v2.8.5) Signed-off-by: dependabot[bot] <support@dependabot.com> * Bump @types/mongodb from 3.0.18 to 3.1.18 Bumps [@types/mongodb](https://github.com/DefinitelyTyped/DefinitelyTyped) from 3.0.18 to 3.1.18. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits) Signed-off-by: dependabot[bot] <support@dependabot.com> * More test cases * Bump mongoose from 5.1.0 to 5.4.1 Bumps [mongoose](https://github.com/Automattic/mongoose) from 5.1.0 to 5.4.1. - [Release notes](https://github.com/Automattic/mongoose/releases) - [Changelog](https://github.com/Automattic/mongoose/blob/master/History.md) - [Commits](Automattic/mongoose@5.1.0...5.4.1) Signed-off-by: dependabot[bot] <support@dependabot.com> * update npm packages * Fix typo * Fix typos and make sure tests work * Add documentation and comments * remove WIP material * Remove debug constants * Change team services to also update hacker * Bump dotenv from 5.0.1 to 6.2.0 (#240) Bumps [dotenv](https://github.com/motdotla/dotenv) from 5.0.1 to 6.2.0. - [Release notes](https://github.com/motdotla/dotenv/releases) - [Changelog](https://github.com/motdotla/dotenv/blob/master/CHANGELOG.md) - [Commits](motdotla/dotenv@v5.0.1...v6.2.0) Signed-off-by: dependabot[bot] <support@dependabot.com> * Update regex pattern * change to enum validation (#259) * Revert "Bump jsonwebtoken from 8.3.0 to 8.4.0" This reverts commit e1cb108. * Revert "Bump bcrypt from 3.0.0 to 3.0.3" This reverts commit e40d783. * Revert "Bump @google-cloud/storage from 2.3.1 to 2.3.4" This reverts commit 1b4c8a2. * Revert "Bump nodemon from 1.17.3 to 1.18.9" This reverts commit 8b09373. * Revert "Bump @types/express from 4.11.1 to 4.16.0" This reverts commit 24f564e. * Revert "Bump multer from 1.3.1 to 1.4.1" This reverts commit c05f136. * Revert "Bump express from 4.16.3 to 4.16.4" This reverts commit d9ce20d. * Revert "Bump chai-http from 4.0.0 to 4.2.0" This reverts commit fc1f73d. * Revert "version 1.1.2" This reverts commit 4c81019. * Revert "Develop (#225)" This reverts commit 24a2748. * Bump chai-http from 4.0.0 to 4.2.1 Bumps [chai-http](https://github.com/chaijs/chai-http) from 4.0.0 to 4.2.1. - [Release notes](https://github.com/chaijs/chai-http/releases) - [Changelog](https://github.com/chaijs/chai-http/blob/master/History.md) - [Commits](chaijs/chai-http@4.0.0...4.2.1) Signed-off-by: dependabot[bot] <support@dependabot.com> * Bump @types/mongoose from 5.3.5 to 5.3.6 Bumps [@types/mongoose](https://github.com/DefinitelyTyped/DefinitelyTyped) from 5.3.5 to 5.3.6. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits) Signed-off-by: dependabot[bot] <support@dependabot.com> * change errors * Bump mongoose from 5.4.1 to 5.4.2 Bumps [mongoose](https://github.com/Automattic/mongoose) from 5.4.1 to 5.4.2. - [Release notes](https://github.com/Automattic/mongoose/releases) - [Changelog](https://github.com/Automattic/mongoose/blob/master/History.md) - [Commits](Automattic/mongoose@5.4.1...5.4.2) Signed-off-by: dependabot[bot] <support@dependabot.com> * Bump @types/mongoose from 5.3.6 to 5.3.7 Bumps [@types/mongoose](https://github.com/DefinitelyTyped/DefinitelyTyped) from 5.3.6 to 5.3.7. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits) Signed-off-by: dependabot[bot] <support@dependabot.com> * Make projectName optional * add next * Fix bug where new Team validator looked for name, not teamName * Update docs * Change all instances of teamName to name * Add check for hacker joining same team * comments * Make more items editable (#269) * Make more items editable * Update docs * Add flags to mongoose connection (#272) * Add invite route (#252) * Add invite route * Documentation * Feature/team get (#270) * Add routes and roles * add showTeam with member names * create tests * Create middleware to display member names and add auth * documentation and function commenting * add some more test details * docs and typo * Change findMemberNames to use Mongoose.populate * Change documentation to so param type is ObjectId * Move id for get to be in req.param * Fix documentation, make test cases more detailed * Feature/team post (#273) * change to enum validation * Add authentication to team create * Create team * Add tests for team * WIP team post duplication issue * Add check for duplicate team name, and test for hacker already being in a team * uncomment tests * fix git merge mistake * Remove testing code, make sure create also updates hacker * docs * Remove test index * re-add index on team name * fix merge issue * Feature/274 stats query (#275) * Add query param to stats * Docs * Fix test * Feature/278 team leave (#279) * Add route * Change success name, add tests * Fix api_data * Add removeTeamIfEmpty * Add leave to hackerRole * Bug fix * General team bugfixes * fn name change * Remove console.log * Change function name * Feature/team patch (#277) * WIP team patch * WIP team patch * docs and tests * fix merge issue * WIP patch * Commenting, fix parsePatch, remove unused function * PR comments * Description and errors * Fix bracket issue * Change link (#282) * Bump mongoose from 5.4.2 to 5.4.3 Bumps [mongoose](https://github.com/Automattic/mongoose) from 5.4.2 to 5.4.3. - [Release notes](https://github.com/Automattic/mongoose/releases) - [Changelog](https://github.com/Automattic/mongoose/blob/master/History.md) - [Commits](Automattic/mongoose@5.4.2...5.4.3) Signed-off-by: dependabot[bot] <support@dependabot.com> * create volunteer get route (#285) * create volunteer get route * docs * Finish route, add tests, update documentation (#289) HackerByEmail route, add tests, update documentation * 290 acceptance email (#291) * edits * typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR patches the search route and adds more documentation. I did none of the work here but just doing the emergency PR to get this out ASAP.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: