Skip to content

Bugfix/sponsor role binding #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 15, 2019
Merged

Bugfix/sponsor role binding #288

merged 8 commits into from
Jan 15, 2019

Conversation

@pierreTklein
Copy link
Member

@pierreTklein pierreTklein commented Jan 10, 2019

Description

General bugfixes with respect to Sponsors.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@pierreTklein pierreTklein mentioned this pull request Jan 13, 2019
Merged
YiFeiZhang2
YiFeiZhang2 requested changes Jan 15, 2019
View reviewed changes
Copy link
Member

@YiFeiZhang2 YiFeiZhang2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@pierreTklein pierreTklein merged commit 85f9ca5 into develop Jan 15, 2019
@loreina loreina deleted the bugfix/sponsorRoleBinding branch November 21, 2019 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YiFeiZhang2 YiFeiZhang2 YiFeiZhang2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pierreTklein @YiFeiZhang2