Skip to content

Conversation

@YiFeiZhang2
Copy link
Member

Description

Create route for sponsor update.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Made new tests

  • fail due to authentication
  • fail due to authorization
  • fail due to wrong sponsor id
  • success to update sponsor

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@pierreTklein pierreTklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just 2 changes for documentation

@pierreTklein pierreTklein merged commit 35abfbd into develop Jan 21, 2019
@loreina loreina deleted the feature/sponsor_patch branch July 30, 2020 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants