Skip to content

Conversation

@pierreTklein
Copy link
Member

@pierreTklein pierreTklein commented Jul 31, 2020

Tickets:

fixes: #658

List of changes:

  • Delete VERSION
  • Read from package.json

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Locally

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Listed change(s) in the Changelog
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@pierreTklein pierreTklein requested a review from loreina July 31, 2020 20:48
loreina
loreina previously requested changes Aug 1, 2020
Copy link
Member

@loreina loreina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick search, I think we read VERSION from at least bin/www.js and routes/index.js. might be other places too

edit: wait I see they call version service, should we change syntax to lowercase for those too or keep uppercase?

@pierreTklein pierreTklein requested review from logan-r and loreina August 1, 2020 15:11
@pierreTklein pierreTklein requested review from logan-r and loreina and removed request for logan-r and loreina October 12, 2020 01:07
Copy link
Member

@logan-r logan-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge!

@pierreTklein pierreTklein merged commit e4523fc into dev Oct 16, 2020
@pierreTklein pierreTklein deleted the bugfix/read-version-service branch October 16, 2020 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect version number is returned from API

4 participants