Skip to content

Conversation

@logan-r
Copy link
Member

@logan-r logan-r commented Nov 26, 2021

Tickets:

  • HAC-

List of changes:

  • Github action was not properly loading environment variable when running test, this fixes that

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

  • After migrating away from Travis CI, github action didn't properly load env vars. No longer specifying path to env to fix this issue.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New release
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Questions for code reviewers?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Listed change(s) in the Changelog
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@logan-r logan-r temporarily deployed to testing November 26, 2021 23:39 Inactive
@logan-r logan-r marked this pull request as ready for review November 26, 2021 23:54
@logan-r logan-r temporarily deployed to testing November 26, 2021 23:58 Inactive
Copy link
Member

@brarsanmol brarsanmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@brarsanmol brarsanmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deploy was successful, we are good to go.

@logan-r logan-r merged commit baa5146 into dev Nov 27, 2021
@logan-r logan-r deleted the fix-ci-tests branch November 27, 2021 20:21
logan-r added a commit that referenced this pull request Nov 29, 2021
* fix: properly load env in ci

* refactor: remove unused comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants