From 27ed5655939bfe7a853e4ced432e4297846c750a Mon Sep 17 00:00:00 2001 From: Anmol Brar Date: Mon, 6 Dec 2021 13:49:14 -0500 Subject: [PATCH] fix: application submitted page not being shown due to failed confirmation check. - forgotten account confirmation check on the findSelf function in the hacker middleware allowed constant 409 requests. - IMPORTANT: this issue has a ripple effect in the sponsor and volunteer middleware from what i understand as the code is the same in the findSelf functions in both classes. - i would recommend patching both or resolving the e-mail billing issue before the sponsor and volunteer onboarding. --- middlewares/hacker.middleware.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/middlewares/hacker.middleware.js b/middlewares/hacker.middleware.js index 78a4ad72..fa75accb 100644 --- a/middlewares/hacker.middleware.js +++ b/middlewares/hacker.middleware.js @@ -841,8 +841,7 @@ async function checkDuplicateAccountLinks(req, res, next) { */ async function findSelf(req, res, next) { if ( - req.user.accountType != Constants.General.HACKER || - !req.user.confirmed + req.user.accountType != Constants.General.HACKER /*|| !req.user.confirmed*/ ) { return next({ status: 409,