Permalink
Browse files

Fix wrong maxAgeSeconds multiplication

It seems like the inital work on the hsts module expected milliseconds.
This has either changed or was never true. Either way, it caused that
the current defaults resulted in theory in a 1000 year HSTS policy.
Luckily helmet was smart enough to not go higher than 1 year.

Anyway, this patch fixes the multiplication of the configured size with
1000 by removing this multiplication.

Also to simplify the reading of the defaults, we split them into their
components, 60 times 60 seconds so we get one hour. 24 of those hours so
we get a day and finally 365 days to get our original wanted default of
one year.

Reference:
d69d65e
Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
  • Loading branch information...
SISheogorath committed Nov 19, 2018
1 parent 271dff3 commit 0aa3116805f899fb3a97e4c7b22c05e91ac1016f
Showing with 2 additions and 2 deletions.
  1. +1 −1 app.js
  2. +1 −1 lib/config/default.js
2 app.js
@@ -83,7 +83,7 @@ app.use(compression())
// use hsts to tell https users stick to this
if (config.hsts.enable) {
app.use(helmet.hsts({
maxAge: config.hsts.maxAgeSeconds * 1000,
maxAge: config.hsts.maxAgeSeconds,
includeSubdomains: config.hsts.includeSubdomains,
preload: config.hsts.preload
}))
@@ -13,7 +13,7 @@ module.exports = {
useSSL: false,
hsts: {
enable: true,
maxAgeSeconds: 31536000,
maxAgeSeconds: 60 * 60 * 24 * 365,
includeSubdomains: true,
preload: true
},

0 comments on commit 0aa3116

Please sign in to comment.