From 2921fc08737d808a1225e2ac0476a626954f1307 Mon Sep 17 00:00:00 2001
From: shohhei1126 <shohheiitoh@gmail.com>
Date: Tue, 30 Apr 2024 10:03:35 +0000
Subject: [PATCH] fix uploads

---
 app.js                 | 2 +-
 deployments/Dockerfile | 1 +
 lib/config/default.js  | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/app.js b/app.js
index b1b387bb28..e294ffdacb 100644
--- a/app.js
+++ b/app.js
@@ -227,7 +227,7 @@ app.locals.enableGitHubGist = config.isGitHubEnable
 app.locals.enableGitlabSnippets = config.isGitlabSnippetsEnable
 
 app.use('/uploads', (req, res, next) => {
-  if (req.session.user) next()
+  if (req.isAuthenticated()) next()
   else response.errorNotFound(req, res)
 }, express.static(path.resolve(__dirname, config.uploadsPath), { maxAge: config.staticCacheTime }))
 
diff --git a/deployments/Dockerfile b/deployments/Dockerfile
index 532a099cc9..17547f484f 100644
--- a/deployments/Dockerfile
+++ b/deployments/Dockerfile
@@ -23,6 +23,7 @@ USER hackmd
 ENV QT_QPA_PLATFORM=offscreen
 WORKDIR /home/hackmd/app
 COPY --chown=1500:1500 --from=BUILD /home/hackmd/app .
+RUN mkdir /tmp/uploads
 RUN npm install --production && npm cache clean --force && rm -rf /tmp/{core-js-banners,phantomjs}
 EXPOSE 3000
 ENTRYPOINT ["/home/hackmd/app/docker-entrypoint.sh"]
diff --git a/lib/config/default.js b/lib/config/default.js
index d276e46eff..f444a61fea 100644
--- a/lib/config/default.js
+++ b/lib/config/default.js
@@ -48,7 +48,7 @@ module.exports = {
   tmpPath: os.tmpdir(),
   defaultNotePath: './public/default.md',
   docsPath: './public/docs',
-  uploadsPath: './public/uploads',
+  uploadsPath: '/tmp/uploads',
   // session
   sessionName: 'connect.sid',
   sessionSecret: 'secret',