Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some XSS issues #1112

Merged
merged 2 commits into from Dec 29, 2018

Conversation

Projects
None yet
2 participants
@jackycute
Copy link
Member

jackycute commented Dec 28, 2018

  • Fix to sanitize disqus shortnames to remove slashes [Security Issue]
  • Fix to escape html comment tag [Security Issue]
Fix to sanitize disqus shortnames to remove slashes [Security Issue]
Signed-off-by: Max Wu <jackymaxj@gmail.com>

@jackycute jackycute requested a review from SISheogorath Dec 28, 2018

Fix to escape html comment tag [Security Issue]
Signed-off-by: Max Wu <jackymaxj@gmail.com>
@SISheogorath
Copy link
Member

SISheogorath left a comment

LGTM

@SISheogorath SISheogorath merged commit dba9575 into master Dec 29, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@SISheogorath

This comment has been minimized.

Copy link
Member

SISheogorath commented Dec 29, 2018

Thanks a lot!

@SISheogorath SISheogorath deleted the fix-XSS-issues branch Dec 29, 2018

@SISheogorath SISheogorath added this to the 1.3.0 release milestone Dec 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.