Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shown but broken GitLab snippets #1131

Merged
merged 1 commit into from Mar 9, 2019

Conversation

Projects
None yet
1 participant
@SISheogorath
Copy link
Member

SISheogorath commented Jan 25, 2019

To provide a GitLab integration we need the GitLab integration to be
configured. Otherwise we shouldn't show the Snippet button.

This patch adds the requirement to the variable that decides if the
import from snippets button shows up or not.

@SISheogorath SISheogorath added the bug label Jan 25, 2019

@SISheogorath SISheogorath added this to the 1.3.0 release milestone Jan 25, 2019

@SISheogorath SISheogorath force-pushed the SISheogorath:fix/gitlabSnippets branch 2 times, most recently from e006339 to a4b183d Mar 5, 2019

Fix shown but broken GitLab snippets
To provide a GitLab integration we need the GitLab integration to be
configured. Otherwise we shouldn't show the Snippet button.

This patch adds the requirement to the variable that decides if the
import from snippets button shows up or not.

Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>

@SISheogorath SISheogorath force-pushed the SISheogorath:fix/gitlabSnippets branch from a4b183d to bcb7972 Mar 5, 2019

@SISheogorath SISheogorath merged commit 329d39d into hackmdio:master Mar 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@SISheogorath SISheogorath deleted the SISheogorath:fix/gitlabSnippets branch Mar 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.