Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade mermaid to 8.2.3 #1242

Merged
merged 5 commits into from Jul 29, 2019

Conversation

@jackycute
Copy link
Member

jackycute commented Jul 28, 2019

to avoid XSS inside the svg tag

Signed-off-by: Max Wu jackymaxj@gmail.com

see issue #1233

@jackycute jackycute requested a review from a60814billy Jul 28, 2019
jackycute added 3 commits Jul 28, 2019
to avoid XSS inside the svg tag

Signed-off-by: Max Wu <jackymaxj@gmail.com>
Signed-off-by: Max Wu <jackymaxj@gmail.com>
Signed-off-by: Max Wu <jackymaxj@gmail.com>
@jackycute jackycute force-pushed the feature/upgrade-mermaid-for-xss branch from 4bf2160 to f1680ef Jul 28, 2019
@jackycute jackycute requested review from Yukaii and removed request for a60814billy Jul 28, 2019
@Yukaii
Yukaii approved these changes Jul 28, 2019
Copy link
Member

Yukaii left a comment

LGTM 🍾

@jackycute

This comment has been minimized.

Copy link
Member Author

jackycute commented Jul 29, 2019

Thanks @Yukaii

@jackycute jackycute merged commit ce914ad into develop Jul 29, 2019
2 checks passed
2 checks passed
DCO DCO
Details
Travis CI - Pull Request Build Passed
Details
@jackycute jackycute deleted the feature/upgrade-mermaid-for-xss branch Jul 29, 2019
@Yukaii Yukaii added this to the 1.4.0 Release milestone Aug 3, 2019
pandy1988 pushed a commit to pandy1988/codimd that referenced this pull request Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.