Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/naming #1248

Closed
wants to merge 3 commits into from
Closed

Fix/naming #1248

wants to merge 3 commits into from

Conversation

@dragetd
Copy link

dragetd commented Aug 2, 2019

Fixes #1219

We probably should bump the version to reflect this change, as it requires existing configs to be updated.

I also fixed the environment variables to reflect the change. This needs some testing. Once we agree on the version and have things tested, this PR is no longer WIP. :)

@dragetd dragetd force-pushed the draget-forks:fix/naming branch 3 times, most recently from 8c899eb to c259b6d Aug 2, 2019
@dragetd

This comment has been minimized.

Copy link
Author

dragetd commented Aug 6, 2019

Rebased the PR onto most recent develop. Updated the screenshots to show the right name.

@dragetd dragetd changed the title WIP: Fix/naming Fix/naming Aug 6, 2019
dragetd added 3 commits Aug 2, 2019
Only changes all mentions of the name to proper 'hackmd'

Signed-off-by: Michael Gajda <draget@speciesm.net>
Be consistent with legacy variables and the project name.

Signed-off-by: Michael Gajda <draget@speciesm.net>
Signed-off-by: Michael Gajda <draget@speciesm.net>
@dragetd dragetd force-pushed the draget-forks:fix/naming branch from c259b6d to e5d222d Aug 7, 2019
@dragetd

This comment has been minimized.

Copy link
Author

dragetd commented Aug 7, 2019

Rebased on current develop. Travis is failing - not sure if this has to do something with renaming of the variables. Checking on this later, unless someone else catches it first. :P

@dragetd

This comment has been minimized.

Copy link
Author

dragetd commented Aug 27, 2019

Did anyone check why travis was failing?

@dragetd

This comment has been minimized.

Copy link
Author

dragetd commented Sep 6, 2019

I am trying to take a step towards the project here and help out with the suggested name-hange as discussed in #1219 . I took the effort to also edit screenshots and check/fix URLs.

I'd really appreciate at least some sort of feedback to #1219 and how to progress from here.

@dragetd

This comment has been minimized.

Copy link
Author

dragetd commented Sep 21, 2019

Any news on this side or #1219 ?

@dragetd

This comment has been minimized.

Copy link
Author

dragetd commented Jan 8, 2020

knock knock, is this thing even on?

@unteem unteem mentioned this pull request Jan 22, 2020
@jackycute

This comment has been minimized.

Copy link
Member

jackycute commented Mar 19, 2020

Hi @dragetd,
Thanks for pull request.
We have no plan to change the name at the moment.

@jackycute jackycute closed this Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.