Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken images in PDF caused by misconfigred server URL #857

Merged
merged 1 commit into from Jun 23, 2018

Conversation

Projects
None yet
2 participants
@SISheogorath
Copy link
Contributor

commented Jun 23, 2018

As it turns out, if the serverURL can't be generated correctly, HackMD
will use relative paths in image upload. This causes broken links in
PDF.

With this commit we force absolute links during PDF creation which
hopefully fixes the problem.

Fixes #820

Fix broken images in PDF caused by misconfigred server URL
As it turns out, if the serverURL can't be generated correctly, HackMD
will use relative paths in image upload. This causes broken links in
PDF.

With this commit we force absolute links during PDF creation which
hopefully fixes the problem.

Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>

@SISheogorath SISheogorath added the bug label Jun 23, 2018

@SISheogorath SISheogorath added this to the 1.2.0-CE Release milestone Jun 23, 2018

@SISheogorath SISheogorath merged commit ec78c4f into master Jun 23, 2018

4 checks passed

DCO All commits have a DCO sign-off from the author
Details
License Compliance All checks passed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@SISheogorath SISheogorath deleted the fix/pdf-links branch Jun 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.