New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for missing doc comments #102

Merged
merged 1 commit into from Jul 15, 2014

Conversation

Projects
None yet
3 participants
@bharrisau
Contributor

bharrisau commented Jul 15, 2014

First step in phasing over to deny mode. There are 129 missing comments
at the moment - the warning is to prevent the creation of more as
we catch up.

@bharrisau bharrisau referenced this pull request Jul 15, 2014

Closed

Set 'missing doc attribute' to deny for zinc.rs #82

0 of 6 tasks complete
@farcaller

This comment has been minimized.

Member

farcaller commented Jul 15, 2014

Can you apply the same to platformtree crate please? It also needs lots of docs.

Add warning for missing doc comments
First step in phasing over to deny mode. There are 129 missing comments
at the moment - the warning is to prevent the creation of more as
we catch up.
@bharrisau

This comment has been minimized.

Owner

bharrisau commented on 01fe568 Jul 15, 2014

r=farcaller

@bharrisau

This comment has been minimized.

Contributor

bharrisau commented Jul 15, 2014

Done.

@hacknbot

This comment has been minimized.

Contributor

hacknbot commented on 01fe568 Jul 15, 2014

saw approval from farcaller
at bharrisau@01fe568

This comment has been minimized.

Contributor

hacknbot replied Jul 15, 2014

merging bharrisau/zinc/doc-comment = 01fe568 into auto

This comment has been minimized.

Contributor

hacknbot replied Jul 15, 2014

bharrisau/zinc/doc-comment = 01fe568 merged ok, testing candidate = 3a5bbd5

This comment has been minimized.

Member

farcaller replied Jul 15, 2014

r+

This comment has been minimized.

Contributor

hacknbot replied Jul 15, 2014

This comment has been minimized.

Contributor

hacknbot replied Jul 15, 2014

fast-forwarding master to auto = 3a5bbd5

hacknbot added a commit that referenced this pull request Jul 15, 2014

Merge pull request #102 from bharrisau/doc-comment
Add warning for missing doc comments

Reviewed-by: farcaller

@hacknbot hacknbot merged commit 01fe568 into hackndev:master Jul 15, 2014

2 checks passed

continuous-integration/travis-ci The Travis CI build passed
Details
default all tests passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment