New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert missing documentation for hal/cortex_common #103

Merged
merged 2 commits into from Jul 15, 2014

Conversation

Projects
None yet
4 participants
@bharrisau
Contributor

bharrisau commented Jul 15, 2014

This also adds a new function to get the current value of the systick register. The K20 hal hasn't got a stable timer yet, so the example app is using systick without interrupts. It should ultimately be fixed, but at the moment I'm just focusing on the doc comments.

Is it OK to have a function to get the current SYSTICK value? Should it be get_current instead?

@bharrisau bharrisau referenced this pull request Jul 15, 2014

Closed

Set 'missing doc attribute' to deny for zinc.rs #82

0 of 6 tasks complete
@farcaller

This comment has been minimized.

Member

farcaller commented Jul 15, 2014

I still didn't make up my mind on getters naming, but I think I slightly prefer the get_ prefix

Add function to get the current value of systick
The k20 example app doesn't use an interrupt, so it needs the systick
value.
@bharrisau

This comment has been minimized.

Contributor

bharrisau commented Jul 15, 2014

r?

@bharrisau

This comment has been minimized.

Contributor

bharrisau commented Jul 15, 2014

How great is git commit --fixup and git rebase --autosquash. Only just found them!

@farcaller

This comment has been minimized.

Member

farcaller commented Jul 15, 2014

Heh, TIL

@farcaller

This comment has been minimized.

Member

farcaller commented on eed6b97 Jul 15, 2014

r+

This comment has been minimized.

Contributor

hacknbot replied Jul 15, 2014

saw approval from farcaller
at bharrisau@eed6b97

This comment has been minimized.

Contributor

hacknbot replied Jul 15, 2014

merging bharrisau/zinc/cortex-commons = eed6b97 into auto

This comment has been minimized.

Contributor

hacknbot replied Jul 15, 2014

bharrisau/zinc/cortex-commons = eed6b97 merged ok, testing candidate = 4556ab4

This comment has been minimized.

Contributor

hacknbot replied Jul 15, 2014

This comment has been minimized.

Contributor

hacknbot replied Jul 15, 2014

fast-forwarding master to auto = 4556ab4

@bharrisau

This comment has been minimized.

Owner

bharrisau commented on eed6b97 Jul 15, 2014

r=farcaller

hacknbot added a commit that referenced this pull request Jul 15, 2014

Merge pull request #103 from bharrisau/cortex-commons
Insert missing documentation for hal/cortex_common

Reviewed-by: farcaller

@hacknbot hacknbot merged commit eed6b97 into hackndev:master Jul 15, 2014

2 checks passed

continuous-integration/travis-ci The Travis CI build passed
Details
default all tests passed
Details
@bgamari

This comment has been minimized.

Contributor

bgamari commented Jul 15, 2014

Concerning the K20's lack of a timer, I have an LPT implementation sitting around but it's waiting for the register code to stabilize.

@bharrisau bharrisau deleted the bharrisau:cortex-commons branch Jul 15, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment