New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for flash clock config at frequency 20<x<=40 #107

Merged
merged 1 commit into from Jul 17, 2014

Conversation

Projects
None yet
4 participants
@blaxill
Contributor

blaxill commented Jul 16, 2014

Original code had a typo.

@bharrisau

This comment has been minimized.

Contributor

bharrisau commented Jul 17, 2014

Thanks for this, I'm surprised there wasn't a warning for unreachable code. Any chance you can reply with a link to the relevant datasheet, lpc17xx isn't my platform.

@blaxill

This comment has been minimized.

Contributor

blaxill commented Jul 17, 2014

http://www.nxp.com/documents/user_manual/UM10360.pdf
Table 49 on Page 71

Function looks correct now to me.

@bharrisau

This comment has been minimized.

Contributor

bharrisau commented Jul 17, 2014

Thanks.

@hacknbot

This comment has been minimized.

Contributor

hacknbot commented on 5020ff8 Jul 17, 2014

This comment has been minimized.

Contributor

hacknbot replied Jul 17, 2014

merging blaxill/zinc/patch-1 = 5020ff8 into auto

This comment has been minimized.

Contributor

hacknbot replied Jul 17, 2014

blaxill/zinc/patch-1 = 5020ff8 merged ok, testing candidate = a461d72

This comment has been minimized.

Contributor

hacknbot replied Jul 17, 2014

This comment has been minimized.

Contributor

hacknbot replied Jul 17, 2014

fast-forwarding master to auto = a461d72

hacknbot added a commit that referenced this pull request Jul 17, 2014

Merge pull request #107 from blaxill/patch-1
Fix for flash clock config at frequency 20<x<=40

Reviewed-by: bharrisau

@hacknbot hacknbot merged commit 5020ff8 into hackndev:master Jul 17, 2014

2 checks passed

continuous-integration/travis-ci The Travis CI build passed
Details
default all tests passed
Details
@farcaller

This comment has been minimized.

Member

farcaller commented Jul 17, 2014

Thanks for finding that!

PS: I filed rust-lang/rust#15736 for rust, I wonder if the compiler could do anything to prevent this.

@blaxill blaxill deleted the blaxill:patch-1 branch Jul 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment