Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] warning: use of deprecated item: prefer using indexing #112

Merged
merged 1 commit into from Jul 19, 2014

Conversation

Projects
None yet
3 participants
@errordeveloper
Copy link
Member

commented Jul 19, 2014

Fixing this in just the src/hal/lpc17xx/pin_pt.rs first results in:

error: mismatched types: expected `core::option::Option<std::collections::hashmap::HashMap<collections::string::String,uint>>` but found an `&`-pointer pattern

Fixing the above error, gives this:

error: cannot move out of dereference (dereference is implicit, due to indexing)
@farcaller

This comment has been minimized.

Copy link
Member

commented Jul 19, 2014

Indexing is back, awesome!

@farcaller

This comment has been minimized.

Copy link

commented on 9f1bced Jul 19, 2014

r+

@hacknbot

This comment has been minimized.

Copy link
Contributor

commented on 9f1bced Jul 19, 2014

saw approval from farcaller
at errordeveloper@9f1bced

This comment has been minimized.

Copy link
Contributor

replied Jul 19, 2014

merging errordeveloper/zinc/use_index_instead_of_get = 9f1bced into auto

This comment has been minimized.

Copy link
Contributor

replied Jul 19, 2014

errordeveloper/zinc/use_index_instead_of_get = 9f1bced merged ok, testing candidate = a1c1d99

This comment has been minimized.

Copy link
Contributor

replied Jul 19, 2014

Merge sha f0f5267 is stale.

This comment has been minimized.

Copy link
Contributor

replied Jul 19, 2014

merging errordeveloper/zinc/use_index_instead_of_get = 9f1bced into auto

This comment has been minimized.

Copy link
Contributor

replied Jul 19, 2014

merging errordeveloper/zinc/use_index_instead_of_get = 9f1bced into auto

This comment has been minimized.

Copy link
Contributor

replied Jul 19, 2014

errordeveloper/zinc/use_index_instead_of_get = 9f1bced merged ok, testing candidate = 14d541a

This comment has been minimized.

Copy link
Contributor

replied Jul 19, 2014

Merge sha dbb16bd is stale.

This comment has been minimized.

Copy link
Contributor

replied Jul 19, 2014

merging errordeveloper/zinc/use_index_instead_of_get = 9f1bced into auto

This comment has been minimized.

Copy link
Contributor

replied Jul 19, 2014

errordeveloper/zinc/use_index_instead_of_get = 9f1bced merged ok, testing candidate = 00c3b53

hacknbot added a commit that referenced this pull request Jul 19, 2014

Merge pull request #112 from errordeveloper/use_index_instead_of_get
[fix] warning: use of deprecated item: prefer using indexing

Reviewed-by: farcaller

hacknbot added a commit that referenced this pull request Jul 19, 2014

Merge pull request #112 from errordeveloper/use_index_instead_of_get
[fix] warning: use of deprecated item: prefer using indexing

Reviewed-by: farcaller

hacknbot added a commit that referenced this pull request Jul 19, 2014

Merge pull request #112 from errordeveloper/use_index_instead_of_get
[fix] warning: use of deprecated item: prefer using indexing

Reviewed-by: farcaller

hacknbot added a commit that referenced this pull request Jul 19, 2014

Merge pull request #112 from errordeveloper/use_index_instead_of_get
[fix] warning: use of deprecated item: prefer using indexing

Reviewed-by: farcaller

hacknbot added a commit that referenced this pull request Jul 19, 2014

Merge pull request #112 from errordeveloper/use_index_instead_of_get
[fix] warning: use of deprecated item: prefer using indexing

Reviewed-by: farcaller

hacknbot added a commit that referenced this pull request Jul 19, 2014

Merge pull request #112 from errordeveloper/use_index_instead_of_get
[fix] warning: use of deprecated item: prefer using indexing

Reviewed-by: farcaller

hacknbot added a commit that referenced this pull request Jul 19, 2014

Merge pull request #112 from errordeveloper/use_index_instead_of_get
[fix] warning: use of deprecated item: prefer using indexing

Reviewed-by: farcaller

farcaller added a commit that referenced this pull request Jul 19, 2014

Merge pull request #112 from errordeveloper/use_index_instead_of_get
[fix] warning: use of deprecated item: prefer using indexing

@farcaller farcaller merged commit ead61f6 into hackndev:master Jul 19, 2014

1 of 2 checks passed

default running tests for candidate 00c3b53e456cd3d9e332829ecd37096a197f8dc7
Details
continuous-integration/travis-ci The Travis CI build passed
Details

@bharrisau bharrisau referenced this pull request Jul 20, 2014

Closed

Fix for latest rustc. #114

@errordeveloper errordeveloper deleted the errordeveloper:use_index_instead_of_get branch Jul 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.