New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some cleanup of files and todos #122

Merged
merged 1 commit into from Jul 31, 2014

Conversation

Projects
None yet
3 participants
@bharrisau
Contributor

bharrisau commented Jul 31, 2014

We should be using UnsafeCell, but we can't until there is some movement
on using static with internal mutability (we should technically be using
static mut, as static should be in the rodata section).

Also dropped the stats collection in favour of parsing the Travis logs.

Some cleanup of files and todos
We should be using UnsafeCell, but we can't until there is some movement
on using static with internal mutability (we should technically be using
static mut, as static should be in the rodata section).

Also dropped the stats collection in favour of parsing the Travis logs.
@farcaller

This comment has been minimized.

farcaller commented on 08edf3c Jul 31, 2014

r+

@hacknbot

This comment has been minimized.

Contributor

hacknbot commented on 08edf3c Jul 31, 2014

saw approval from farcaller
at bharrisau@08edf3c

This comment has been minimized.

Contributor

hacknbot replied Jul 31, 2014

merging bharrisau/zinc/cleanup1 = 08edf3c into auto

This comment has been minimized.

Contributor

hacknbot replied Jul 31, 2014

bharrisau/zinc/cleanup1 = 08edf3c merged ok, testing candidate = 2f0c71b

This comment has been minimized.

Contributor

hacknbot replied Jul 31, 2014

Merge sha b021b1c is stale.

This comment has been minimized.

Contributor

hacknbot replied Jul 31, 2014

merging bharrisau/zinc/cleanup1 = 08edf3c into auto

This comment has been minimized.

Contributor

hacknbot replied Jul 31, 2014

merging bharrisau/zinc/cleanup1 = 08edf3c into auto

This comment has been minimized.

Contributor

hacknbot replied Jul 31, 2014

bharrisau/zinc/cleanup1 = 08edf3c merged ok, testing candidate = d05c797

This comment has been minimized.

Contributor

hacknbot replied Jul 31, 2014

Merge sha 352af6a is stale.

This comment has been minimized.

Contributor

hacknbot replied Jul 31, 2014

merging bharrisau/zinc/cleanup1 = 08edf3c into auto

This comment has been minimized.

Contributor

hacknbot replied Jul 31, 2014

bharrisau/zinc/cleanup1 = 08edf3c merged ok, testing candidate = 1f62cb8

hacknbot added a commit that referenced this pull request Jul 31, 2014

Merge pull request #122 from bharrisau/cleanup1
Some cleanup of files and todos

Reviewed-by: farcaller

hacknbot added a commit that referenced this pull request Jul 31, 2014

Merge pull request #122 from bharrisau/cleanup1
Some cleanup of files and todos

Reviewed-by: farcaller

hacknbot added a commit that referenced this pull request Jul 31, 2014

Merge pull request #122 from bharrisau/cleanup1
Some cleanup of files and todos

Reviewed-by: farcaller

hacknbot added a commit that referenced this pull request Jul 31, 2014

Merge pull request #122 from bharrisau/cleanup1
Some cleanup of files and todos

Reviewed-by: farcaller

farcaller added a commit that referenced this pull request Jul 31, 2014

Merge pull request #122 from bharrisau/cleanup1
Some cleanup of files and todos

@farcaller farcaller merged commit e81a134 into hackndev:master Jul 31, 2014

1 of 2 checks passed

default running tests for candidate 1f62cb85dc73272127cf22c0e73992bc6442dd74
Details
continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment