New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the `ioreg!` macro to `ioreg_old!` #127

Merged
merged 1 commit into from Aug 7, 2014

Conversation

Projects
None yet
3 participants
@bharrisau
Contributor

bharrisau commented Aug 7, 2014

Indentation alignment isn't corrected, but the _old suffix is ugly
anyway.

Move the `ioreg!` macro to `ioreg_old!`
Indentation alignment isn't corrected, but the `_old` suffix is ugly
anyway.
@farcaller

This comment has been minimized.

Member

farcaller commented Aug 7, 2014

r, whenever this is finished.

@bharrisau

This comment has been minimized.

Contributor

bharrisau commented Aug 7, 2014

Was waiting for Travis. But I guess bors will test it anyway.

@bharrisau

This comment has been minimized.

Owner

bharrisau commented on 2edb925 Aug 7, 2014

r=farcaller

This comment has been minimized.

Owner

bharrisau replied Aug 7, 2014

r-

@hacknbot

This comment has been minimized.

Contributor

hacknbot commented on 2edb925 Aug 7, 2014

saw approval from farcaller
at bharrisau@2edb925

This comment has been minimized.

Contributor

hacknbot replied Aug 7, 2014

merging bharrisau/zinc/ioreg_rename = 2edb925 into auto

This comment has been minimized.

Contributor

hacknbot replied Aug 7, 2014

bharrisau/zinc/ioreg_rename = 2edb925 merged ok, testing candidate = 6047409

This comment has been minimized.

Contributor

hacknbot replied Aug 7, 2014

Merge sha c046956 is stale.

This comment has been minimized.

Contributor

hacknbot replied Aug 7, 2014

merging bharrisau/zinc/ioreg_rename = 2edb925 into auto

This comment has been minimized.

Contributor

hacknbot replied Aug 7, 2014

bharrisau/zinc/ioreg_rename = 2edb925 merged ok, testing candidate = c8b2994

This comment has been minimized.

Contributor

hacknbot replied Aug 7, 2014

Merge sha 5955517 is stale.

This comment has been minimized.

Contributor

hacknbot replied Aug 7, 2014

merging bharrisau/zinc/ioreg_rename = 2edb925 into auto

This comment has been minimized.

Contributor

hacknbot replied Aug 7, 2014

bharrisau/zinc/ioreg_rename = 2edb925 merged ok, testing candidate = 93fc12a

hacknbot added a commit that referenced this pull request Aug 7, 2014

Merge pull request #127 from bharrisau/ioreg_rename
Move the `ioreg!` macro to `ioreg_old!`

Reviewed-by: farcaller

hacknbot added a commit that referenced this pull request Aug 7, 2014

Merge pull request #127 from bharrisau/ioreg_rename
Move the `ioreg!` macro to `ioreg_old!`

Reviewed-by: farcaller

hacknbot added a commit that referenced this pull request Aug 7, 2014

Merge pull request #127 from bharrisau/ioreg_rename
Move the `ioreg!` macro to `ioreg_old!`

Reviewed-by: farcaller
@bharrisau

This comment has been minimized.

Contributor

bharrisau commented Aug 7, 2014

Looks like they are going to race one another?

farcaller added a commit that referenced this pull request Aug 7, 2014

Merge pull request #127 from bharrisau/ioreg_rename
Move the `ioreg!` macro to `ioreg_old!`

@farcaller farcaller merged commit 27d4c9c into hackndev:master Aug 7, 2014

1 of 2 checks passed

default running tests for candidate 93fc12ac37b1fcb02c40f4e94b11deb5aadbce46
Details
continuous-integration/travis-ci The Travis CI build passed
Details
@farcaller

This comment has been minimized.

Member

farcaller commented Aug 7, 2014

Yes, they are.

@farcaller

This comment has been minimized.

Member

farcaller commented Aug 7, 2014

Happens every time, I need to look into bors. And look into other supporting server thingies, gah. Will try to fix this issue over the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment